diff options
author | Vasily Averin <vvs@virtuozzo.com> | 2015-06-25 15:01:47 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-25 17:00:39 -0700 |
commit | 3ea4331c60be3eee4c97e5ddabad95399f879b76 (patch) | |
tree | 6977f3c7a8a72003f3b324de5ce4bb490274ff53 /net/batman-adv/packet.h | |
parent | d194e5d666225b04c7754471df0948f645b6ab3a (diff) |
check_syslog_permissions() cleanup
Patch fixes drawbacks in heck_syslog_permissions() noticed by AKPM:
"from_file handling makes me cry.
That's not a boolean - it's an enumerated value with two values
currently defined.
But the code in check_syslog_permissions() treats it as a boolean and
also hardwires the knowledge that SYSLOG_FROM_PROC == 1 (or == `true`).
And the name is wrong: it should be called from_proc to match
SYSLOG_FROM_PROC."
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Josh Boyer <jwboyer@redhat.com>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/batman-adv/packet.h')
0 files changed, 0 insertions, 0 deletions