summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorBrenden Blanco <bblanco@plumgrid.com>2016-10-13 13:13:11 -0700
committerDavid S. Miller <davem@davemloft.net>2016-10-14 11:13:00 -0400
commit958b3d396d7f80755e2c2e6a8f873a669f38de10 (patch)
tree01942edbde4e8ea94f2130e53953183a308879f0 /include
parentfbbfa34c2c25f163515d5229a6cbdff243588f88 (diff)
net/mlx4_en: fixup xdp tx irq to match rx
In cases where the number of tx rings is not a multiple of the number of rx rings, the tx completion event will be handled on a different core from the transmit and population of the ring. Races on the ring will lead to a double-free of the page, and possibly other corruption. The rings are initialized by default with a valid multiple of rings, based on the number of cpus, therefore an invalid configuration requires ethtool to change the ring layout. For instance 'ethtool -L eth0 rx 9 tx 8' will cause packets received on rx0, and XDP_TX'd to tx48, to be completed on cpu3 (48 % 9 == 3). Resolve this discrepancy by shifting the irq for the xdp tx queues to start again from 0, modulo rx_ring_num. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Brenden Blanco <bblanco@plumgrid.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions