summaryrefslogtreecommitdiff
path: root/fs/ioprio.c
diff options
context:
space:
mode:
authorChristoph Lameter <cl@linux.com>2014-04-07 15:39:40 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-04-07 16:36:14 -0700
commit3ed66e910c91eb914b5c1f2d434538fe68bb8a56 (patch)
tree66d299fed61f826905b17ecd2a39c4a5fe996425 /fs/ioprio.c
parent08f141d3dbddacb70aba1541bc5f950e466591e9 (diff)
net: replace __this_cpu_inc in route.c with raw_cpu_inc
The RT_CACHE_STAT_INC macro triggers the new preemption checks for __this_cpu ops. I do not see any other synchronization that would allow the use of a __this_cpu operation here however in commit dbd2915ce87e ("[IPV4]: RT_CACHE_STAT_INC() warning fix") Andrew justifies the use of raw_smp_processor_id() here because "we do not care" about races. In the past we agreed that the price of disabling interrupts here to get consistent counters would be too high. These counters may be inaccurate due to race conditions. The use of __this_cpu op improves the situation already from what commit dbd2915ce87e did since the single instruction emitted on x86 does not allow the race to occur anymore. However, non x86 platforms could still experience a race here. Trace: __this_cpu_add operation in preemptible [00000000] code: avahi-daemon/1193 caller is __this_cpu_preempt_check+0x38/0x60 CPU: 1 PID: 1193 Comm: avahi-daemon Tainted: GF 3.12.0-rc4+ #187 Call Trace: check_preemption_disabled+0xec/0x110 __this_cpu_preempt_check+0x38/0x60 __ip_route_output_key+0x575/0x8c0 ip_route_output_flow+0x27/0x70 udp_sendmsg+0x825/0xa20 inet_sendmsg+0x85/0xc0 sock_sendmsg+0x9c/0xd0 ___sys_sendmsg+0x37c/0x390 __sys_sendmsg+0x49/0x90 SyS_sendmsg+0x12/0x20 tracesys+0xe1/0xe6 Signed-off-by: Christoph Lameter <cl@linux.com> Acked-by: David S. Miller <davem@davemloft.net> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Eric Dumazet <edumazet@google.com> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ioprio.c')
0 files changed, 0 insertions, 0 deletions
ffice-4-1-0'>libreoffice-4-1-0 Unnamed repository; edit this file to name it for gitweb.root
summaryrefslogtreecommitdiff
AgeCommit message (Expand)AuthorFilesLines
7 daysupdate translations for master/25-2HEADmasterChristian Lohmaier1000-65153/+77033
13 daysupdate translations for master/25.2.0 Beta1libreoffice-25-2-branch-pointChristian Lohmaier206-944/+3313
2024-12-03update translations for master/25.2Christian Lohmaier793-89515/+94170
2024-12-03Updated Slovenian translationMartin Srebotnjak43-2188/+2389
2024-12-01update translations for master / 25.2Christian Lohmaier2023-147733/+144174
2024-11-22add translation files for Santali (Ol-Chiki) (sat-Olck)Christian Lohmaier158-0/+284480
2024-11-22update translations for master/25.2.0 alpha1Christian Lohmaier1216-130450/+143164
2024-11-21Updated Slovenian translationMartin Srebotnjak64-13501/+19617
2024-11-19update translations for master / 25.2 alpha1Christian Lohmaier1934-72263/+100204
2024-11-05update translations for masterChristian Lohmaier2013-339716/+413548
2024-10-25update translations for masterChristian Lohmaier248-8678/+9001
2024-10-23add Tagalog (tl) translationsChristian Lohmaier220-0/+789621
2024-10-23update translations for masterChristian Lohmaier1725-190947/+231197
2024-10-04update translations for masterChristian Lohmaier2839-243555/+298302
2024-09-17update translations for masterChristian Lohmaier4999-1016811/+1482054
2024-09-06update translations for 24.8.1 rc2Christian Lohmaier294-4826/+4802
2024-08-23update translations for 24.8.1 rc1Christian Lohmaier464-7996/+9278
2024-08-08update translations for 24.8.0 rc3Christian Lohmaier330-7999/+7194
2024-07-26update translations for 24.8.0 rc2/masterChristian Lohmaier78-778/+848
2024-07-24update translations for 24.8.0 rc2Christian Lohmaier334-5629/+5300
2024-07-15update translations for master/24-8Christian Lohmaier449-6941/+7245
2024-07-08update translations for 24.8.0 rc1/masterChristian Lohmaier