diff options
author | NeilBrown <neilb@suse.com> | 2015-07-15 17:54:15 +1000 |
---|---|---|
committer | NeilBrown <neilb@suse.com> | 2015-08-31 19:36:06 +0200 |
commit | c74c0d760e30f56f9699dc180036ca37993d1c58 (patch) | |
tree | c064932e8affe59739303ad7bed313ce3662efcf /drivers/md/md.c | |
parent | 05256d9884d3276f61537d3d7f5605dc21bd3477 (diff) |
md/raid5: remove incorrect "min_t()" when calculating writepos.
This code is calculating:
writepos, which is the furthest along address (device-space) that we
*will* be writing to
readpos, which is the earliest address that we *could* possible read
from, and
safepos, which is the earliest address in the 'old' section that we
might read from after a crash when the reshape position is
recovered from metadata.
The first is a precise calculation, so clipping at zero doesn't
make sense. As the reshape position is now guaranteed to always be
a multiple of reshape_sectors and as we already BUG_ON when
reshape_progress is zero, there is no point in this min_t() call.
The readpos and safepos are worst case - actual value depends on
precise geometry. That worst case could be negative, which is only
a problem because we are storing the value in an unsigned.
So leave the min_t() for those.
Signed-off-by: NeilBrown <neilb@suse.com>
Diffstat (limited to 'drivers/md/md.c')
0 files changed, 0 insertions, 0 deletions