diff options
author | Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> | 2021-09-08 19:27:49 +0900 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2021-09-08 18:52:04 +0200 |
commit | 8c28051cdcbe9dfcec6bd0a4709d67a09df6edae (patch) | |
tree | bf98d1945cca9a2268bff4715044a3542b5d666f /README | |
parent | 87fd9ef47597b2fcee3264eb5f288410b9f376d5 (diff) |
fbmem: don't allow too huge resolutionsdrm-misc-next-fixes-2021-09-09
syzbot is reporting page fault at vga16fb_fillrect() [1], for
vga16fb_check_var() is failing to detect multiplication overflow.
if (vxres * vyres > maxmem) {
vyres = maxmem / vxres;
if (vyres < yres)
return -ENOMEM;
}
Since no module would accept too huge resolutions where multiplication
overflow happens, let's reject in the common path.
Link: https://syzkaller.appspot.com/bug?extid=04168c8063cfdde1db5e [1]
Reported-by: syzbot <syzbot+04168c8063cfdde1db5e@syzkaller.appspotmail.com>
Debugged-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/185175d6-227a-7b55-433d-b070929b262c@i-love.sakura.ne.jp
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions