diff options
| author | Cheng Lin <cheng.lin130@zte.com.cn> | 2023-10-10 10:09:01 +0800 |
|---|---|---|
| committer | Chandan Babu R <chandanbabu@kernel.org> | 2023-10-23 11:04:47 +0530 |
| commit | 2b99e410b28f5a75ae417e6389e767c7745d6fce (patch) | |
| tree | beaf6a19b63d05c585d731f76aa1740dca2b7843 | |
| parent | 9fa8753aa1f177dfb859ee22daed47c337c84278 (diff) | |
xfs: introduce protection for drop nlink
When abnormal drop_nlink are detected on the inode,
return error, to avoid corruption propagation.
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
| -rw-r--r-- | fs/xfs/xfs_inode.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 4d55f58d99b7..fb85c5c81745 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -918,6 +918,13 @@ xfs_droplink( xfs_trans_t *tp, xfs_inode_t *ip) { + if (VFS_I(ip)->i_nlink == 0) { + xfs_alert(ip->i_mount, + "%s: Attempt to drop inode (%llu) with nlink zero.", + __func__, ip->i_ino); + return -EFSCORRUPTED; + } + xfs_trans_ichgtime(tp, ip, XFS_ICHGTIME_CHG); drop_nlink(VFS_I(ip)); |