diff options
| author | Yuan Can <yuancan@huawei.com> | 2022-09-29 01:55:03 +0000 |
|---|---|---|
| committer | Douglas Anderson <dianders@chromium.org> | 2022-09-29 14:04:25 -0700 |
| commit | c9b48b91e2fbb74fb981aa616a6ef3c78194077f (patch) | |
| tree | 20adc871476253810008a39d464bd785165321dc | |
| parent | b28d204a7c19231c0a37359f82dc8c4b234d1d16 (diff) | |
drm/panel: simple: Use dev_err_probe() to simplify codedrm-misc-next-2022-09-30
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220929015503.17301-3-yuancan@huawei.com
| -rw-r--r-- | drivers/gpu/drm/panel/panel-simple.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f9e1f85daef7..252fd66011cc 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -575,12 +575,9 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) panel->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); - if (IS_ERR(panel->enable_gpio)) { - err = PTR_ERR(panel->enable_gpio); - if (err != -EPROBE_DEFER) - dev_err(dev, "failed to request GPIO: %d\n", err); - return err; - } + if (IS_ERR(panel->enable_gpio)) + return dev_err_probe(dev, PTR_ERR(panel->enable_gpio), + "failed to request GPIO\n"); err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation); if (err) { |