diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-03-07 12:30:58 +0300 |
|---|---|---|
| committer | Alyssa Rosenzweig <alyssa@rosenzweig.io> | 2025-03-14 09:42:11 -0400 |
| commit | ee20c69c789b6cb2179a535cf440d72b98f4a134 (patch) | |
| tree | 680b045170bf1c2076bffcf1063f3b37cbfe6300 | |
| parent | 914ee6e730e134410b77edc453b629767e84c32c (diff) | |
drm: adp: Fix NULL vs IS_ERR() check in adp_plane_new()drm-misc-next-fixes-2025-03-27
The __drmm_universal_plane_alloc() function doesn't return NULL, it
returns error pointers. Update the check to match.
Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/14a845e8-54d0-45f8-b8b9-927609d92ede@stanley.mountain
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
| -rw-r--r-- | drivers/gpu/drm/adp/adp_drv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c index 0eeb9e5fab26..c98c647f981d 100644 --- a/drivers/gpu/drm/adp/adp_drv.c +++ b/drivers/gpu/drm/adp/adp_drv.c @@ -232,9 +232,9 @@ static struct drm_plane *adp_plane_new(struct adp_drv_private *adp) ALL_CRTCS, &adp_plane_funcs, plane_formats, ARRAY_SIZE(plane_formats), NULL, DRM_PLANE_TYPE_PRIMARY, "plane"); - if (!plane) { + if (IS_ERR(plane)) { drm_err(drm, "failed to allocate plane"); - return ERR_PTR(-ENOMEM); + return plane; } drm_plane_helper_add(plane, &adp_plane_helper_funcs); |