diff options
| author | Valentin Rothberg <Valentin.Rothberg@lip6.fr> | 2015-03-01 16:54:32 +0100 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2015-03-09 10:46:15 -0500 |
| commit | 80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2 (patch) | |
| tree | efe161d0d579d74b2e098ad2c7549441887a856a /drivers/usb/isp1760/isp1760-core.c | |
| parent | 1c390eb360c3f6bc9a06d2260eccad195c505de5 (diff) | |
usb: isp1760: set IRQ flags properly
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to
commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts
disabled") running IRQ handlers with interrupts enabled can cause stack
overflows when the interrupt line of the issuing device is still active.
This patch removes using this deprecated flag and additionally removes
redundantly setting IRQF_SHARED for isp1760_udc_register().
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/isp1760/isp1760-core.c')
| -rw-r--r-- | drivers/usb/isp1760/isp1760-core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/isp1760/isp1760-core.c b/drivers/usb/isp1760/isp1760-core.c index b9827556455f..bfa402cf3a27 100644 --- a/drivers/usb/isp1760/isp1760-core.c +++ b/drivers/usb/isp1760/isp1760-core.c @@ -151,8 +151,7 @@ int isp1760_register(struct resource *mem, int irq, unsigned long irqflags, } if (IS_ENABLED(CONFIG_USB_ISP1761_UDC) && !udc_disabled) { - ret = isp1760_udc_register(isp, irq, irqflags | IRQF_SHARED | - IRQF_DISABLED); + ret = isp1760_udc_register(isp, irq, irqflags); if (ret < 0) { isp1760_hcd_unregister(&isp->hcd); return ret; |