diff options
author | Tom Parkin <tparkin@katalix.com> | 2013-03-19 06:11:23 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-03-20 12:10:39 -0400 |
commit | f6e16b299bacaa71c6604a784f2d088a966f8c23 (patch) | |
tree | 115d199ee9cd9fb9dbc296d3daad259cd9e0d682 /Documentation/misc-devices | |
parent | 7b7c0719cd7afee725b920d75ec6a500b76107e6 (diff) |
l2tp: unhash l2tp sessions on delete, not on free
If we postpone unhashing of l2tp sessions until the structure is freed, we
risk:
1. further packets arriving and getting queued while the pseudowire is being
closed down
2. the recv path hitting "scheduling while atomic" errors in the case that
recv drops the last reference to a session and calls l2tp_session_free
while in atomic context
As such, l2tp sessions should be unhashed from l2tp_core data structures early
in the teardown process prior to calling pseudowire close. For pseudowires
like l2tp_ppp which have multiple shutdown codepaths, provide an unhash hook.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/misc-devices')
0 files changed, 0 insertions, 0 deletions