diff options
| author | Andreas Gruenbacher <agruen@linbit.com> | 2014-02-19 10:49:07 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2014-02-21 15:42:34 -0800 |
| commit | f597f6b8dfaa033be3b3b755e6c0ab3caee96dcd (patch) | |
| tree | 048a1e13e96fd13adb322009f71bf7ff07de67be | |
| parent | 2457b6d5ee1a9ff8a3c15ea8eaa5bc195a47d326 (diff) | |
drbd: Fix future possible NULL pointer dereference
Right now every resource has exactly one connection. But we are preparing
for dynamic connections. I.e. in the future thre can be resources without
connections.
However smatch points this out as 'variable dereferenced before check',
which is correct.
This issue was introduced in
drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andreas Gruenbacher <agruen@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | drivers/block/drbd/drbd_nl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 2086b12d3f75..526414bc2cab 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -2776,7 +2776,7 @@ static int nla_put_drbd_cfg_context(struct sk_buff *skb, if (device && nla_put_u32(skb, T_ctx_volume, device->vnr)) goto nla_put_failure; - if (nla_put_string(skb, T_ctx_resource_name, connection->resource->name)) + if (nla_put_string(skb, T_ctx_resource_name, resource->name)) goto nla_put_failure; if (connection) { if (connection->my_addr_len && |