diff options
| author | Ian Forbes <ian.forbes@broadcom.com> | 2024-03-28 14:07:16 -0500 |
|---|---|---|
| committer | Zack Rusin <zack.rusin@broadcom.com> | 2024-06-05 22:38:40 -0400 |
| commit | 5703fc058efdafcdd6b70776ee562478f0753acb (patch) | |
| tree | 47737f0df8eec5e16cac067489bea7be7f0a774b | |
| parent | b91e05f1fcf755c9d2c4ca10907383e39def05bd (diff) | |
drm/vmwgfx: Don't memcmp equivalent pointersdrm-misc-fixes-2024-06-07
These pointers are frequently the same and memcmp does not compare the
pointers before comparing their contents so this was wasting cycles
comparing 16 KiB of memory which will always be equal.
Fixes: bb6780aa5a1d ("drm/vmwgfx: Diff cursors when using cmds")
Signed-off-by: Ian Forbes <ian.forbes@broadcom.com>
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240328190716.27367-1-ian.forbes@broadcom.com
| -rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 9532258a0848..00c4ff684130 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -224,7 +224,7 @@ static bool vmw_du_cursor_plane_has_changed(struct vmw_plane_state *old_vps, new_image = vmw_du_cursor_plane_acquire_image(new_vps); changed = false; - if (old_image && new_image) + if (old_image && new_image && old_image != new_image) changed = memcmp(old_image, new_image, size) != 0; return changed; |