diff options
author | Yuan Can <yuancan@huawei.com> | 2022-11-13 09:29:29 +0000 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-11-14 18:50:53 -0800 |
commit | 280c0f7cd0aa4d190619b18243110e052a90775c (patch) | |
tree | b4862d43e89e8802589f12cf00b301286e561503 /net/kcm | |
parent | 30f5312d2c722107364f266cfa98ef4f0857c1fb (diff) |
net: ionic: Fix error handling in ionic_init_module()
A problem about ionic create debugfs failed is triggered with the
following log given:
[ 415.799514] debugfs: Directory 'ionic' with parent '/' already present!
The reason is that ionic_init_module() returns ionic_bus_register_driver()
directly without checking its return value, if ionic_bus_register_driver()
failed, it returns without destroy the newly created debugfs, resulting
the debugfs of ionic can never be created later.
ionic_init_module()
ionic_debugfs_create() # create debugfs directory
ionic_bus_register_driver()
pci_register_driver()
driver_register()
bus_add_driver()
priv = kzalloc(...) # OOM happened
# return without destroy debugfs directory
Fix by removing debugfs when ionic_bus_register_driver() returns error.
Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
Link: https://lore.kernel.org/r/20221113092929.19161-1-yuancan@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/kcm')
0 files changed, 0 insertions, 0 deletions