diff options
author | Dan Williams <dan.j.williams@intel.com> | 2024-05-29 14:49:01 +0300 |
---|---|---|
committer | Imre Deak <imre.deak@intel.com> | 2024-05-30 12:28:31 +0300 |
commit | f0a267885e4d99325c92af27f972c018479b5f81 (patch) | |
tree | 7f6e2abc562b09485ee4cf24de61e4ae6351a886 /drivers/message | |
parent | 3e5fdd7886b71d1050015b2762a7984dfc97cafa (diff) |
PCI: Make PCI cfg_access_lock lockdep key a singletoncore-for-ci
The new lockdep annotation for cfg_access_lock naively registered a new
key per device. This is overkill and leads to warnings on hash
collisions at dynamic registration time:
WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:1226 lockdep_register_key+0xb0/0x240
RIP: 0010:lockdep_register_key+0xb0/0x240
[..]
Call Trace:
<TASK>
? __warn+0x8c/0x190
? lockdep_register_key+0xb0/0x240
? report_bug+0x1f8/0x200
? handle_bug+0x3c/0x70
? exc_invalid_op+0x18/0x70
? asm_exc_invalid_op+0x1a/0x20
? lockdep_register_key+0xb0/0x240
pci_device_add+0x14b/0x560
? pci_setup_device+0x42e/0x6a0
pci_scan_single_device+0xa7/0xd0
p2sb_scan_and_cache_devfn+0xc/0x90
p2sb_fs_init+0x15f/0x170
Switch to a shared static key for all instances.
Fixes: 7e89efc6e9e4 ("PCI: Lock upstream bridge for pci_reset_function()")
Reported-by: Jani Saarinen <jani.saarinen@intel.com>
Closes: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14834/bat-apl-1/boot0.txt
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
References: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11223
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240529114901.344655-1-imre.deak@intel.com
Diffstat (limited to 'drivers/message')
0 files changed, 0 insertions, 0 deletions