diff options
author | Huayu Chen <huayu.chen@corigine.com> | 2023-01-31 17:30:33 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-02-01 19:57:30 -0800 |
commit | ca3daf437d9c261ca498f518090c3ddbf1bf824f (patch) | |
tree | 896d9df22930cecfcc2a3e229103d4ed7531559c /drivers/firmware | |
parent | bc61761394ce0f0cc35c6fc60426f08d83d0d488 (diff) |
nfp: correct cleanup related to DCB resources
This patch corrects two oversights relating to releasing resources
and DCB initialisation.
1. If mapping of the dcbcfg_tbl area fails: an error should be
propagated, allowing partial initialisation (probe) to be unwound.
2. Conversely, if where dcbcfg_tbl is successfully mapped: it should
be unmapped in nfp_nic_dcb_clean() which is called via various error
cleanup paths, and shutdown or removal of the PCIE device.
Fixes: 9b7fe8046d74 ("nfp: add DCB IEEE support")
Signed-off-by: Huayu Chen <huayu.chen@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20230131163033.981937-1-simon.horman@corigine.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/firmware')
0 files changed, 0 insertions, 0 deletions