diff options
| author | Qiuxu Zhuo <qiuxu.zhuo@intel.com> | 2023-12-07 09:45:12 +0800 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2024-01-02 09:20:08 -0800 |
| commit | 1e92af09fab1b5589f3a7ae68109e3c6a5ca6c6e (patch) | |
| tree | 552b634cd9e85fce9452f72a99282e1416455139 /drivers/edac | |
| parent | a69badad736c0f460401080a67e6208e25ab25e2 (diff) | |
EDAC/skx_common: Filter out the invalid address
Decoding an invalid address with certain firmware decoders could
cause a #PF (Page Fault) in the EFI runtime context, which could
subsequently hang the system. To make {i10nm,skx}_edac more robust
against such bogus firmware decoders, filter out invalid addresses
before allowing the firmware decoder to process them.
Suggested-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20231207014512.78564-1-qiuxu.zhuo@intel.com
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/skx_common.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c index ce3e0069e028..9c5b6f8bd8bd 100644 --- a/drivers/edac/skx_common.c +++ b/drivers/edac/skx_common.c @@ -648,6 +648,10 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val, memset(&res, 0, sizeof(res)); res.mce = mce; res.addr = mce->addr & MCI_ADDR_PHYSADDR; + if (!pfn_to_online_page(res.addr >> PAGE_SHIFT)) { + pr_err("Invalid address 0x%llx in IA32_MC%d_ADDR\n", mce->addr, mce->bank); + return NOTIFY_DONE; + } /* Try driver decoder first */ if (!(driver_decode && driver_decode(&res))) { |