summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-07-20 21:52:37 +0800
committerTakashi Iwai <tiwai@suse.de>2021-07-20 16:08:21 +0200
commit7f6726b63595c7ec8bc410364ab3be6cf4d4d407 (patch)
tree70e249fc9caf2c4e5274580f3b822673202c4384
parent3a1e341c5687b4e8fe51ca1c933b1f23ab3304c1 (diff)
ALSA: nm256: Fix error return code in snd_nm256_create()
If pci_request_regions() fails, it should return error code in snd_nm256_create(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210720135237.3424521-1-yangyingliang@huawei.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/nm256/nm256.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index a54b9b26a0c2..c9c178504959 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -1478,7 +1478,8 @@ snd_nm256_create(struct snd_card *card, struct pci_dev *pci)
chip->buffer_addr = pci_resource_start(pci, 0);
chip->cport_addr = pci_resource_start(pci, 1);
- if (pci_request_regions(pci, card->driver))
+ err = pci_request_regions(pci, card->driver);
+ if (err < 0)
return err;
/* Init the memory port info. */