From c90d16d9553ddbc7852aa0b0dfe1c6282ed2e464 Mon Sep 17 00:00:00 2001 From: amorales Date: Tue, 12 Nov 2013 16:45:40 +0000 Subject: * src/src/mp3-c.c:: Fix compiler warning with clang: mp3-c.c:1669:64: error: comparison of unsigned expression < 0 is always false git-svn-id: https://core.fluendo.com/gstreamer/svn/trunk/gst-fluendo-mp3@2524 2b0047a9-a6d8-0310-accf-f7200b2a168c --- ChangeLog | 6 ++++++ src/mp3-c.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 324ffd2..01b6c1c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2013-11-12 Andoni Morales + + * src/src/mp3-c.c:: + Fix compiler warning with clang: + mp3-c.c:1669:64: error: comparison of unsigned expression < 0 is always false + 2013-09-04 Release Maker * configure.ac: Back to TRUNK. diff --git a/src/mp3-c.c b/src/mp3-c.c index 9ec187e..c011c6f 100644 --- a/src/mp3-c.c +++ b/src/mp3-c.c @@ -1644,6 +1644,7 @@ c_decode_mp3 (mp3tl * tl) III_side_info_t III_side_info; huffdec_bitbuf *bb; guint gr, ch, sb; + gint diff; fr_header *hdr; guint8 side_info[32]; /* At most 32 bytes side info for MPEG-1 stereo */ @@ -1666,7 +1667,8 @@ c_decode_mp3 (mp3tl * tl) /* Check that we have enough main_data between the bit reservoir * and the incoming data */ - if (tl->c_impl.main_data_end - III_side_info.main_data_begin < 0) { + diff = tl->c_impl.main_data_end - III_side_info.main_data_begin; + if (diff < 0) { /* Usually happens after a seek. We can't decode this frame */ GST_LOG ("Not enough main data available to decode frame"); return MP3TL_ERR_BAD_FRAME; -- cgit v1.2.3