diff options
author | Sam Lantinga <slouken@libsdl.org> | 2012-01-10 22:52:17 -0500 |
---|---|---|
committer | Sam Lantinga <slouken@libsdl.org> | 2012-01-10 22:52:17 -0500 |
commit | c5dfc3ea64596faa3d7a9fbefee718831cec9abd (patch) | |
tree | 6a94df6926c902708e1ec99100fdd758948b9253 | |
parent | f2adec4ba6de6ba432c98e2e125b61007a14d34a (diff) |
Fixed typo in mask comparison
Bl0ckeduser
I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:
} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {
":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment
I discussed this with another programmer and we came to the conclusion
that this is probably a typo.
I have checked the latest mercurial sources, and the possible typo is
still there.
Bl0ckeduser
--HG--
branch : SDL-1.2
-rw-r--r-- | src/video/SDL_video.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c index b226e03768..46285c990e 100644 --- a/src/video/SDL_video.c +++ b/src/video/SDL_video.c @@ -987,7 +987,7 @@ SDL_Surface *SDL_DisplayFormatAlpha(SDL_Surface *surface) if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) { rmask = 0xff; bmask = 0xff0000; - } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) { + } else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) { amask = 0x000000FF; rmask = 0x0000FF00; gmask = 0x00FF0000; |