diff options
author | Yaron Keren <yaron.keren@gmail.com> | 2014-05-01 12:33:26 +0000 |
---|---|---|
committer | Yaron Keren <yaron.keren@gmail.com> | 2014-05-01 12:33:26 +0000 |
commit | 3152576ea4768187f545efbffa1b542ab48eb9bc (patch) | |
tree | afba298ed89c962cd414739a22ee5019a1ac51b0 | |
parent | 3c5651a00307ba58ed31c72376ba6aeb018f7625 (diff) |
Update post-r203364 http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140303/207915.html
and ranged for loops.
http://reviews.llvm.org/D3582
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207755 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | docs/ProgrammersManual.rst | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/docs/ProgrammersManual.rst b/docs/ProgrammersManual.rst index 9f388cc63f..d545cb2b34 100644 --- a/docs/ProgrammersManual.rst +++ b/docs/ProgrammersManual.rst @@ -1738,16 +1738,12 @@ chain of ``F``: Function *F = ...; - for (Value::use_iterator i = F->use_begin(), e = F->use_end(); i != e; ++i) - if (Instruction *Inst = dyn_cast<Instruction>(*i)) { + for (User *U : GV->users()) { + if (Instruction *Inst = dyn_cast<Instruction>(U)) { errs() << "F is used in instruction:\n"; errs() << *Inst << "\n"; } -Note that dereferencing a ``Value::use_iterator`` is not a very cheap operation. -Instead of performing ``*i`` above several times, consider doing it only once in -the loop body and reusing its result. - Alternatively, it's common to have an instance of the ``User`` Class (`doxygen <http://llvm.org/doxygen/classllvm_1_1User.html>`__) and need to know what ``Value``\ s are used by it. The list of all ``Value``\ s used by a ``User`` is @@ -1759,8 +1755,8 @@ instruction uses (that is, the operands of the particular ``Instruction``): Instruction *pi = ...; - for (User::op_iterator i = pi->op_begin(), e = pi->op_end(); i != e; ++i) { - Value *v = *i; + for (Use& U : pi->operands()) { + Value *v = U.get(); // ... } |