diff options
| author | Tapani Pälli <tapani.palli@intel.com> | 2020-06-04 11:44:33 +0300 |
|---|---|---|
| committer | Tapani Pälli <tapani.palli@intel.com> | 2020-06-04 11:49:15 +0300 |
| commit | 7dd1f8b88a195d43c6d796a222b51d86f888bfa2 (patch) | |
| tree | b487705de188feee90da75a795cdd330702a797c | |
| parent | 58e7466f80d0c32421a505e90cadbe1229c44b53 (diff) | |
ext_external_objects: set img,mem objects NULL after destroy
This is done to play safe with error handling and no need to set them
NULL outside the function.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
| -rw-r--r-- | tests/spec/ext_external_objects/vk.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/tests/spec/ext_external_objects/vk.c b/tests/spec/ext_external_objects/vk.c index b5f219601..6e39fac02 100644 --- a/tests/spec/ext_external_objects/vk.c +++ b/tests/spec/ext_external_objects/vk.c @@ -900,19 +900,21 @@ vk_create_ext_image(struct vk_ctx *ctx, fail: fprintf(stderr, "Failed to create external image.\n"); vk_destroy_ext_image(ctx, img); - img->img = VK_NULL_HANDLE; - img->mem = VK_NULL_HANDLE; return false; } void vk_destroy_ext_image(struct vk_ctx *ctx, struct vk_image_obj *img_obj) { - if (img_obj->img != VK_NULL_HANDLE) + if (img_obj->img != VK_NULL_HANDLE) { vkDestroyImage(ctx->dev, img_obj->img, 0); + img_obj->img = VK_NULL_HANDLE; + } - if (img_obj->mem != VK_NULL_HANDLE) + if (img_obj->mem != VK_NULL_HANDLE) { vkFreeMemory(ctx->dev, img_obj->mem, 0); + img_obj->mem = VK_NULL_HANDLE; + } } bool |