Age | Commit message (Collapse) | Author | Files | Lines |
|
This doesn't seem to be used for anything, and creates an artificial
dependency on gcrypt, which GNUTLS 3 no longer uses.
Verified to pass tests on Debian's gnutls26 2.12.16-1 package, but
insufficient to make tests pass on gnutls28 3.0.12-1.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43992
Bug-Debian: http://bugs.debian.org/638420
|
|
We don't include stdlib.h (except accidentally, via gcrypt.h), which we
should if we're going to use its functions. In both cases GLib has a
portable version, and our coding style is generally to prefer the GLib
versions of things, so let's use those.
|
|
|
|
These changes enables us to cross-compile wocky for windows with mingw32
|
|
They are needed for wocky_caps_hash_compute_from_lists().
https://bugs.freedesktop.org/show_bug.cgi?id=43891
|
|
|
|
Code that we don't build won't build.
|
|
|
|
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=43584
|
|
field->raw_value_contents was not initialized when the field was not coming
from a WockyNode. It leads to a segfault in add_field_to_node_using_default().
The following code was triggering the crash:
form = g_object_new (WOCKY_TYPE_DATA_FORM, NULL);
wocky_data_form_set_string (form, "field", "value", TRUE);
wocky_data_form_add_to_node (form, ...);
This patch initializes field->raw_value_contents when the WockyNode is created
through data_form_set_value().
The unit tests are updated to check this.
https://bugs.freedesktop.org/show_bug.cgi?id=43584
|
|
|
|
|
|
|
|
g_utf8_validate
In some cases valid utf-8, but for non-character codepoints gets send
through xmpp. Other parts of the system can get confused by those (e.g.
D-Bus doesn't allow them in strings). So we need to ensure that they get
filtered out as soon as possible.
There are two obvious places to do this, either in the XmppReader or
the Nodes. Doing it in the nodes has the advantage of ensuring
consistency for all data going into the Node, not just what was read
from xmpp directly. Furthermore the Node api calls already copy the
strings internally, which is a good place place to do the conversions if
needed.
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=42509
|
|
|
|
This makes it easier to verify that a node has the name and namespace
you expect.
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
This is useful in writing an XMPP console for Gabble.
|
|
For really specialised cases, like an XML console in Gabble, you want to
be able to match stanzas of any type. The docs claim you can do this,
but they lie.
I could be convinced that the correct way to do this is to add a fourth
method, wocky_porter_register_handler_for_any_stanza (), and that the
server/anyone/from variants are unnecessary. Thoughts?
https://bugs.freedesktop.org/show_bug.cgi?id=38577
|
|
|
|
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
A second try.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
We could have upped the dependency on libsasl2 but given this is just
a test I thought it wasn't worth the bother of having to make sure
everyone had the newer library version and blah blah blah, so I just
did this.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Some servers does not set the full/bare jid.
Fixes fdo#39057
|
|
|
|
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=42652
|
|
|
|
|
|
wocky-test-sasl-auth-server.c: In function ‘test_sasl_auth_server_new’:
wocky-test-sasl-auth-server.c:932:17: error: expected ‘)’ before ‘proc’
wocky-test-sasl-auth-server.c:932:22: error: expected ‘)’ before ‘(’ token
wocky-test-sasl-auth-server.c:932:30: error: expected ‘}’ before ‘test_sasl_server_auth_log’
wocky-test-sasl-auth-server.c:933:5: error: initialization from incompatible pointer type [-Werror]
wocky-test-sasl-auth-server.c:933:5: error: (near initialization for ‘callbacks[1].proc’) [-Werror]
wocky-test-sasl-auth-server.c: At top level: wocky-test-sasl-auth-server.c:886:1: error: ‘test_sasl_server_auth_log’
defined but not used [-Werror=unused-function]
|
|
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Related to: fd.o#41719
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Fixes: fd.o#41719
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Use the glib.h header instead.
|
|
<presence/> was being interpreted as a docbook tag; and the second
bullet is no longer true: only PEP updates in particular known
namespaces are considered unimportant.
|
|
|
|
This stops gtk-doc even generating the legacy .tmpl files, for a
marginally faster (and less crufty) documentation build process.
|
|
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
|
|
It was legal before, but the tree it built made no sense!
|
|
Previously I had erroneously done this:
...
<items xmlns="the:node:name">
...
Where actually, it should be:
...
<items node="the:node:name">
...
Bad me.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
I feel threatened.
|
|
|
|
Failing to connect to the server specified by an SRV record doesn't mean
the record is wrong: it could well be that the server is broken.
Reviewed-by: Danielle Madeley <danielle.madeley@collabora.co.uk>
|
|
Thanks, clang!
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Some of the fields in the response wocky sends to the server require
the realm (like the "realm" field) while others require the server name
(like the "digest-uri" field). Usually this bug is not noticeable as the
realm and the server name are the same.
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
|
|
|