Age | Commit message (Collapse) | Author | Files | Lines |
|
If setlocale() to our test locale fails, translations
won't work either.
https://bugzilla.gnome.org/show_bug.cgi?id=654017
|
|
See https://bugzilla.gnome.org/show_bug.cgi?id=658999 for why this would
be bad.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
We didn't previously test anything except the implicit default of TRUE.
Now we test implicit TRUE, explicit TRUE, explicit FALSE, and
disconnecting at the local end (which regressed while fixing Bug #651268).
Also avoid some questionable use of a main context, which fell foul of
Bug #658999 and caused this test to be disabled in master.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=662100
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
This was a regression caused by my previous work on GDBusWorker thread-safety
(Bug #651268). The symptom is that if you disconnect a GDBusConnection
locally, the default implementation of GDBusConnection::closed
terminates your process, even though it shouldn't do that for
locally-closed connections; this is because GDBusWorker didn't think a
cancelled read was a local close.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=662100
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
Otherwise, if the caller of _g_dbus_worker_new immediately unrefs the
worker, calling _g_dbus_worker_thread_begin_func in the worker thread
could be a use-after-free.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
This member is written in _g_dbus_worker_stop from arbitrary threads, and
read by the worker thread, so it should be accessed atomically.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
We can't safely close the output part of the I/O stream until any
pending write or flush has been completed. In the worst case, this could
lead to an assertion failure in the worker (when the close wins the
race) or not closing the stream at all (when the write wins the race).
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
num_writes_pending was a counter, but it only took values 0 or 1, so make
it a boolean: it would never make sense to be trying to write out two
messages at the same time (they'd get interleaved).
Similarly, we can never be writing and flushing at the same time (that'd
mean we were flushing halfway through a message, which would be pointless)
so combine it with flush_pending too, calling the result output_pending.
Also assert that it takes the expected value whenever we change it,
and document the locking discipline used for it, including a subtle
case in write_message_in_idle_cb where it's not obvious at first glance
why we don't need the lock.
(Having the combined boolean at the top of the block of write-related
struct members improves struct packing on 64-bit platforms, by packing
read_num_ancillary_messages and output_pending into one word.)
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=651268
Bug-NB: NB#271520
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
* Do not ignore the system default
* Do not exclude the last used being set from the default list
This fixes the default applications dialog in control-center.
https://bugzilla.gnome.org/show_bug.cgi?id=658188
|
|
|
|
|
|
|
|
Sorry, copied the wrong text for these files... redid this.
|
|
Tell people about the GNOME Live! page that outlines building
GLib and its dependencies with Visual C++.
|
|
|
|
|
|
Define USE_SYSTEM_PCRE for all configurations which uses the PCRE that was
already built and "installed" beforehand (i.e. the *_ExtPCRE
configurations) so that the compilation will not pick up the GLib-bundled
pcre.h when one wants to use the PCRE "installation" on his/her system.
|
|
|
|
|
|
|
|
Otherwise there is no point in gracefully handling the error...
https://bugzilla.gnome.org/show_bug.cgi?id=655664
Signed-off-by: David Zeuthen <davidz@redhat.com>
|
|
|
|
|
|
|
|
|
|
Some valid PEM file would not work because the private key was put
before the certificate.
|
|
Missed the bin/gsettings.exe part (corrected from bin/gsettings.)
|
|
|
|
Tell people not to compile GLib in paths containing spaces.
|
|
|
|
This file should have Windows CRLF EOL as well...
|
|
This time I realized that I needed to set autocrlf=false on my Windows side
... ugh...
This is one of those files that must have CRLF line endings to work
correctly :|
|
|
|
|
-Reinstate the temporarily removed glib.sln file for VS10--make its EOL
in the DOS/Windows format so that it will not end up with "Unrecognized
Visual Studio Version" in Windows.
-Updated GLib projects to set the GLib DLL/LIB files to be output to
<Debug or Release>\<Win32 or x64>\bin for all configurations
-Updated property sheets to copy the GLib DLL/LIB for all configurations
-Update VS9 property sheet to seperate Intermediate directories for all
projects as well to reduce warnings/errors of being unable to write the
PDB and related files as they are in use
|
|
-To fix the line endings here...
|
|
Consolidate my previous commit into the property file... should have
realized sooner.
|
|
-Seperate intermediate directories for each project to avoid intermittent
MSBuild errors that a build log cannot be written while in use, and
update the property sheet as necessary.
-Minor cleanups of uneeded tags in the projects/properties
|
|
These tools require the use of GModule headers also, so update the include
directories so that the correct gmodule.h will be included instead of the
system-installed version.
|
|
Provide a fuller description and lead people away if they arrived
here just looking for a way to provide a regular D-Bus service.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|