summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2013-09-11 16:24:42 +0200
committerGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2013-11-15 13:57:40 +0100
commitdda3f6c4ee2e695dbc111023dc9fa7fa53ab4827 (patch)
tree0c9e7673e3c0496a20cba079454eb66e6852d4c5
parent2e22420b7abfbce1c764bafc5c6ce4877561ad5d (diff)
menu_removed_cb: call g_menu_model_get_n_items() once
No need to call it during each iteration. https://bugzilla.gnome.org/show_bug.cgi?id=707885
-rw-r--r--src/empathy-roster-window.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/empathy-roster-window.c b/src/empathy-roster-window.c
index 8280861e..5b4e987b 100644
--- a/src/empathy-roster-window.c
+++ b/src/empathy-roster-window.c
@@ -1341,10 +1341,11 @@ roster_window_favorite_chatroom_menu_removed_cb (
EmpathyRosterWindow *self)
{
GList *chatrooms;
- gint i;
+ guint i, n;
- for (i = 0; i < g_menu_model_get_n_items (
- G_MENU_MODEL (self->priv->rooms_section)); i++)
+ n = g_menu_model_get_n_items (G_MENU_MODEL (self->priv->rooms_section));
+
+ for (i = 0; i < n; i++)
{
const gchar *name;