diff options
author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2013-09-11 16:27:04 +0200 |
---|---|---|
committer | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2013-11-15 13:57:50 +0100 |
commit | 1d8e6474075b44fdf6ae9e11b0e7e3b9578d159e (patch) | |
tree | a9c2c78d7c9caf92141efeb8137310c8357537a9 | |
parent | dda3f6c4ee2e695dbc111023dc9fa7fa53ab4827 (diff) |
menu_removed_cb: fix 'name' leak
https://bugzilla.gnome.org/show_bug.cgi?id=707885
-rw-r--r-- | src/empathy-roster-window.c | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/src/empathy-roster-window.c b/src/empathy-roster-window.c index 5b4e987b..cd1aabb1 100644 --- a/src/empathy-roster-window.c +++ b/src/empathy-roster-window.c @@ -1347,16 +1347,22 @@ roster_window_favorite_chatroom_menu_removed_cb ( for (i = 0; i < n; i++) { - const gchar *name; + gchar *name; - if (g_menu_model_get_item_attribute ( - G_MENU_MODEL (self->priv->rooms_section), i, "room-name", - "s", &name) - && !tp_strdiff (name, empathy_chatroom_get_name (chatroom))) + if (!g_menu_model_get_item_attribute ( + G_MENU_MODEL (self->priv->rooms_section), i, + "room-name", "s", &name)) + continue; + + if (tp_strdiff (name, empathy_chatroom_get_name (chatroom))) { - g_menu_remove (self->priv->rooms_section, i); - break; + g_free (name); + continue; } + + g_menu_remove (self->priv->rooms_section, i); + g_free (name); + break; } chatrooms = empathy_chatroom_manager_get_chatrooms ( |