Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
libXtaw is used by the Xt tests.
Signed-off-by: Peter Harris <pharris@opentext.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
t003() selects for key events on the root window. t005() takes over and then
complains when the focus correctly follows the pointer and an event is
delivered to the root window. If you don't expect events on the root window,
unselect them first.
We could also XCloseDisplay() at the end of each test but who knows what that
does to the other tests.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
|
|
XDeviceKeyEvent and XKeyEvent are _not_ binary compatible. Expecting a random
byte location inside the device event to be of the value it'd have in a core
event is an amusing pasttime, but highly inappropriate for a test.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
|
|
Coccinelle patch:
@@
type T;
@@
- (T *)NULL
+ NULL
with a bit of manual massaging to skip botched hunks
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Don't declare where not needed, include stdlib where needed, don't cast
where not necessary.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
IsXExtensionPointer/Keyboard were introduced with XI 1.4, check for those
too before claiming there aren't any devices.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
|
|
Crashes XSetDeviceFocus and probably everything else in XI that relies on
d = getenv("DISPLAY");
dpy = XOpenDisplay(d);
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Chase Douglas <chase.douglas@canonical.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
CHANGES, README.old and RELEASE come from the previous millenium and
probably don't help much. Autotooling the package totally obsoleted
makefile.old files. Clean this up.
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
In Perl before 5.14, the following syntax was happily accepted:
foreach my $foo qw(bar baz)
but that's been deprecated and that now generates a warning:
Use of qw(...) as parentheses is deprecated at ./xts5/bin/xts-config line 118.
The correct form has always been:
foreach my $foo (qw(bar baz))
and that's compatible with older Perl releases, so let's use that.
Reference:
http://perldoc.perl.org/perl5140delta.html
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
It is used in several places, without an explicit dependency.
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
15|692 3.3-lite 1|TCM Start
400|692 1 1 20:00:19|IC Start
200|692 1 20:00:19|TP Start
520|692 1 00023801 1 1|VSW5TESTSUITE PURPOSE 1
520|692 1 00023801 1 2|Assertion XSubImage-1.(A)
520|692 1 00023801 1 3|When the rectangle specified by the x, y, subimage_width
520|692 1 00023801 1 4|and subimage_height arguments is contained in the image
520|692 1 00023801 1 5|ximage, then a call to XSubImage creates a copy of the
520|692 1 00023801 1 6|subimage and returns a pointer to the newly created
520|692 1 00023801 1 7|subimage.
520|692 1 00023801 1 8|METH: For all supported drawables types:
520|692 1 00023801 1 9|METH: Create a drawable.
520|692 1 00023801 1 10|METH: Initialise the drawable.
520|692 1 00023801 1 11|METH: For XYPixmap and ZPixmap:
520|692 1 00023801 1 12|METH: Create an image using XGetImage.
520|692 1 00023801 1 13|METH: Obtain a subimage using XSubImage.
520|692 1 00023801 1 14|METH: Verify that the pixels in the subimage are correctly set using XGetPixel.
520|692 1 00023801 1 15|unexpected signal 8 (SIGFPE) received
220|692 1 2 20:00:19|UNRESOLVED
410|692 1 1 20:00:19|IC End
This test fills pixel color values by using the function mpattern()
and checks the returned image by using the function checksubimage().
Both these functions use color values from the range 0 – 2^depth.
The value 2^depth is stored in an int (32 bit) variable by using
‘mod = 1 << depth’. If ‘depth’ is 32 then ‘mod’ ends up being 0.
This variable ‘mod’ is later used in a modulo operation resulting
in a SIGFPE. This fix corrects the test by using ‘mod = 1 << 31’
instead of 'mod = 1 << depth' for depth >= 32.
Reported-by: Nalluri Harikrishna <nharikrishna@nvidia.com>
Signed-off-by: Nalluri Harikrishna <nharikrishna@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
According to the X11 protocol specification,
"The visual type must be one supported by the screen (or a Match
error results)."
It does not say anything about invalid visual IDs causing Value
errors.
Reported-by: Nalluri Harikrishna <nharikrishna@nvidia.com>
Reported-by: Rahul Singhal <rasinghal@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
This test creates a directory, makes it non-writable, then calls
XWriteBitmapFile to attempt to write to it, expecting it to fail with
BitmapOpenFailed. This works fine when run as a normal user, but when
run as root, writing the file succeeds anyway.
Check the euid and bail out with UNTESTED if it's root.
Reported-by: Abhinav Shukla <abhinavs@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
ConnDis.c uses various Xtrans functions. Even though the Xtrans code itself is
compiled in x11_trans.c, we need to define these preprocessor macros in
ConnDis.c also to get prototypes for various functions. Otherwise, this causes
warnings and a sign-extension bug on 64-bit platforms that can cause crashes:
ConnDis.c: In function ‘_X11TransConnectDisplay’:
ConnDis.c:351:2: warning: implicit declaration of function ‘_X11TransOpenCOTSClient’
ConnDis.c:351:19: warning: assignment makes pointer from integer without a cast
ConnDis.c:355:2: warning: implicit declaration of function ‘_X11TransConnect’
ConnDis.c:357:6: warning: implicit declaration of function ‘_X11TransClose’
ConnDis.c:366:2: warning: implicit declaration of function ‘_X11TransGetPeerAddr’
ConnDis.c:374:2: warning: implicit declaration of function ‘_X11TransConvertAddress’
ConnDis.c:399:5: warning: implicit declaration of function ‘_X11TransSetOption’
ConnDis.c: In function ‘_XConnectDisplay’:
ConnDis.c:521:8: warning: implicit declaration of function ‘_X11TransGetConnectionNumber’
ConnDis.c:522:8: warning: implicit declaration of function ‘_X11TransFreeConnInfo’
ConnDis.c: In function ‘_XDisconnectDisplay’:
ConnDis.c:545:5: warning: implicit declaration of function ‘_X11TransDisconnect’
ConnDis.c: In function ‘_XSendClientPrefix’:
ConnDis.c:588:5: warning: implicit declaration of function ‘_X11TransWritev’
pAllocColorCell[27592]: segfault at 58fe7f0 ip 000000000016670e sp 00007fff0da0c110 error 4 in libxts5proto.so[110000+6a000]
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
This signal is asserted when the controlling terminal changes size,
for example if you're running xts from an xterm and you resize the
window. This causes tests to fail:
70||"VSW5TESTSUITE CASE FillPoly 3"
10|34 /Xproto/pFillPoly 15:28:48|TC Start, scenario ref 71-0
15|34 3.3-lite 3|TCM Start
510|34|system 0: Abandoning testset: caught unexpected signal 28 (unknown signal)
80|34 1 15:28:49|TC End, scenario ref 71-0
These signals can't affect the test environment, so just ignore them
all the time.
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Dan Nicholson <dbn.lists@gmail.com>
|
|
Conversion performed through:
cproto -a -I include -I xts5/include/ xts5/src/lib/checkevent.c
(after which trailing spaces were removed.)
Suggested-by: Walter Harms <wharms@bfs.de>
Signed-off-by: Cyril Brulebois <kibi@debian.org>
[aplattner@nvidia.com: fixed whitespace errors]
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Suggested-by: Walter Harms <wharms@bfs.de>
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Use a forward declaration to avoid moving the function body across the
file.
The following warning goes away accordingly:
| CC checkevent.lo
| checkevent.c:647:10: warning: implicit declaration of function 'check_ext_event' is invalid in C99 [-Wimplicit-function-declaration]
| fail = check_ext_event(good,ev);
| ^
Signed-off-by: Cyril Brulebois <kibi@debian.org>
[aplattner@nvidia.com: Removed unnecessary comment with a typo in it;
it's clear what forward declarations are for.]
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Tell compilers we really meant to assign and then check.
The following warning goes away accordingly:
| CC nextvclass.lo
| nextvclass.c:224:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
| if (comma = strchr(++s, COMMA))
| ~~~~~~^~~~~~~~~~~~~~~~~~~~
| nextvclass.c:224:14: note: use '==' to turn this assignment into an equality comparison
| if (comma = strchr(++s, COMMA))
| ^
| ==
| nextvclass.c:224:14: note: place parentheses around the assignment to silence this warning
| if (comma = strchr(++s, COMMA))
| ^
| ( )
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Since it's too late already when this function is called, let's return
something to match the prototype.
This warning goes away accordingly:
| CC err.lo
| err.c:180:1: warning: control reaches end of non-void function [-Wreturn-type]
| }
| ^
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
It's needed for sleep():
| CC gettime.lo
| gettime.c:159:23: warning: implicit declaration of function 'sleep' is invalid in C99 [-Wimplicit-function-declaration]
| for (i=0; i<10; i++, sleep(2)) {
| ^
It is needed for alarm():
| CC settimeout.lo
| settimeout.c:155:2: warning: implicit declaration of function 'alarm' is invalid in C99 [-Wimplicit-function-declaration]
| alarm((unsigned long)to);
| ^
It is needed for unlink():
| CC checkarea.lo
| checkarea.c:296:2: warning: implicit declaration of function 'unlink' is invalid in C99 [-Wimplicit-function-declaration]
| unlink(name);
| ^
| CC verimage.lo
| verimage.c:307:3: warning: implicit declaration of function 'unlink' is invalid in C99 [-Wimplicit-function-declaration]
| unlink(errfile);
| ^
| CC savimage.lo
| savimage.c:187:6: waning: implicit declaration of function 'unlink' is invalid in C99 [-Wimplicit-function-declaration]
| unlink(name);
| ^
Signed-off-by: Cyril Brulebois <kibi@debian.org>
[aplattner@nvidia.com: squashed several similar commits]
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
It is needed for strcmp():
| CC checkfont.lo
| checkfont.c:492:16: warning: implicit declaration of function 'strcmp' is invalid in C99 [-Wimplicit-function-declaration]
| if (str && strcmp(teststr, str) != 0) {
| ^
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Use void when nothing is actually returned, use int otherwise.
Also update the appropriate header for the void ones. Even though a
comment claims this header is generated automatically from the source
files, that doesn't seem to be the case.
The following warning go away accordingly:
| CC checkevent.lo
| checkevent.c:664:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| check_ext_event(good,ev)
| ^~~~~~~~~~~~~~~
| CC devcntl.lo
| devcntl.c:401:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| devicerelkeys(dev)
| ^~~~~~~~~~~~~
| devcntl.c:537:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| modpress(disp, mask)
| ^~~~~~~~
| devcntl.c:545:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| devmodpress(disp, dev, mask)
| ^~~~~~~~~~~
| devcntl.c:559:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| modrel(disp, mask)
| ^~~~~~
| devcntl.c:567:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| devmodrel(disp, dev, mask)
| ^~~~~~~~~
| devcntl.c:644:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| ismodkey(mask, kc)
| ^~~~~~~~
| devcntl.c:669:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| restoredevstate()
| ^~~~~~~~~~~~~~~
| devcntl.c:681:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| noext(needbutton)
| ^~~~~
| devcntl.c:703:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| nbuttons()
| ^~~~~~~~
| devcntl.c:718:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| getkeycode(display)
| ^~~~~~~~~~
| devcntl.c:741:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| getdevkeycode(display,dev)
| ^~~~~~~~~~~~~
| CC pfcount.lo
| pfcount.c:118:1: waning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| pfcount(pass, fail)
| ^~~~~~~
| pfcount.c:126:1: waning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| rptcounts()
| ^~~~~~~~~
| CC regid.lo
| regid.c:312:1: waning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| regenable()
| ^~~~~~~~~
| regid.c:316:1: waning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| regdisable()
| ^~~~~~~~~~
| CC checkfont.lo
| checkfont.c:155:8: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| static check1prop(XFontStruct *fsp, XFontProp *fp, char *str);
| ~~~~~~ ^
| checkfont.c:451:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| check1prop(fsp, fp, str)
| ^
| CC cursor.lo
| cursor.c:123:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| curofwin(display, cursor, window)
| ^~~~~~~~
| cursor.c:133:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| defcur(display, window)
| ^~~~~~
| cursor.c:165:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
| spriteiswin(display, window)
| ^~~~~~~~~~~
Signed-off-by: Cyril Brulebois <kibi@debian.org>
[aplattner@nvidia.com: Squashed a few similar commits]
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Without this, configure spits out:
| ./configure: line 12748: ac_fn_c_check_member: command not found
| ./configure: line 12762: ac_fn_c_check_type: command not found
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
[aplattner@nvidia.com: fixed whitespace to match surrounding code]
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
config.c: In function ‘initconfig’:
config.c:394: error: passing argument 1 of ‘_initconfig’ from incompatible pointer type
config.c:328: note: expected ‘char * (*)(const char *)’ but argument is of type ‘char * (*)(char *)’
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
startup.c: In function ‘init_xinput’:
startup.c:505: error: passing argument 2 of ‘_xibaddevice’ from incompatible pointer type
/usr/include/X11/extensions/XInput.h:162: note: expected ‘int *’ but argument is of type ‘XID *’
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
XSetModifierMapping reports FAIL due to a different ordering of the
modifiers in the return value. The server keeps the modifiers in a
different format than used by the core protocol. The modifier map
returned by XGetModifierMapping(3) always has the keycodes in
ascending order for each modifier.
A straight input_map[i] == output_map[i] comparison is not enough if
the input map is not in order. Instead, all values for each modifier
need to be compared to find the right modifier.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
[aplattner@nvidia.com: clarification comment added]
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
../../../../xts5/src/libproto/DfltVals.c: In function ‘Gen_Good_Event’:
../../../../xts5/src/libproto/DfltVals.c:395: warning: control reaches end of non-void function
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
../../../../xts5/src/libproto/DfltVals.c:391: warning: return type defaults
to ‘int’
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|