diff options
| author | Gurchetan Singh <gurchetansingh@chromium.org> | 2016-12-19 15:14:18 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-12-20 21:55:45 -0800 |
| commit | 6f6e18ad418978096ea70e6f3c0ceb1ac41e1697 (patch) | |
| tree | e867287d3a2a27b60df6805847cbd1caccfc32cb /amdgpu.c | |
| parent | 44d1fe4264d4968cb8525f5e53f1fcd068dacbc2 (diff) | |
minigbm: consolidate flags
Let's try to organize the flags such that one entry in the supported
combination list implies a certain type of buffer. For example, we only
create linear buffers in our Mediatek, so the following entries are
equivalent:
{DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
BO_USE_RENDERING | BO_USE_SW_READ_RARELY | BO_USE_SW_WRITE_RARELY},
{DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
BO_USE_CURSOR | BO_USE_LINEAR | BO_USE_SW_READ_OFTEN |
BO_USE_SW_WRITE_OFTEN},
Since they both translate into a XRGB8888 linear buffer on Mediatek, let's merge
the two entries. Do similiar operations for every driver.
BUG=none
TEST=try-bots
Change-Id: I0be97c2deec5310f426632f85d1525a1345498e6
Reviewed-on: https://chromium-review.googlesource.com/421499
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Diffstat (limited to 'amdgpu.c')
| -rw-r--r-- | amdgpu.c | 15 |
1 files changed, 10 insertions, 5 deletions
@@ -39,11 +39,16 @@ enum { }; static struct supported_combination combos[5] = { - {DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_NONE, BO_USE_CURSOR | BO_USE_LINEAR}, - {DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_NONE, BO_USE_RENDERING}, - {DRM_FORMAT_XBGR8888, DRM_FORMAT_MOD_NONE, BO_USE_RENDERING}, - {DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE, BO_USE_LINEAR}, - {DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE, BO_USE_RENDERING}, + {DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_NONE, + BO_USE_CURSOR | BO_USE_LINEAR | BO_USE_SW_READ_OFTEN | BO_USE_SW_WRITE_OFTEN}, + {DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_NONE, + BO_USE_RENDERING | BO_USE_SW_READ_RARELY | BO_USE_SW_WRITE_RARELY}, + {DRM_FORMAT_XBGR8888, DRM_FORMAT_MOD_NONE, + BO_USE_RENDERING | BO_USE_SW_READ_RARELY | BO_USE_SW_WRITE_RARELY}, + {DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE, + BO_USE_LINEAR | BO_USE_SW_READ_OFTEN | BO_USE_SW_WRITE_OFTEN}, + {DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE, + BO_USE_RENDERING | BO_USE_SW_READ_RARELY | BO_USE_SW_WRITE_RARELY}, }; static int amdgpu_set_metadata(int fd, uint32_t handle, |