summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-02-01Xrm: NEWTABLE had a memory leak after a memory allocation errorErkki Seppälä1-1/+3
The NEWTABLE macro missed freeing its allocated memory on subsequent memory allocation errors. Added call to Xfree. Variable "table" goes out of scope Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01ImUtil: Handle a memory leak in one early return branchErkki Seppälä1-0/+1
Fixed memory leak by adding Xfree for image Variable "image" goes out of scope Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01ximcp/imRm: Handle leaking colormap_retErkki Seppälä1-0/+4
Fixed memory leak by adding Xfree for colormap_ret Variable "colormap_ret" goes out of scope Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01ximcp/imRmAttr: Handle leaking missing_listErkki Seppälä1-1/+2
Fixed memory leak by adding Xfree and initializing missing_list with NULL Variable "missing_list" goes out of scope Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01ximcp/imRmAttr: Handle leaking colormap_retErkki Seppälä1-1/+3
XFree colormap_ret and initialize it when appropriate. Variable "colormap_ret" goes out of scope Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01xlibi18n/lcGeneric: Initialize uninitialized local variableErkki Seppälä1-1/+1
Using uninitialized value "new" Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01xcmx/cmxColNm: Removed unused assignments to pBuf (in two functions)Erkki Seppälä1-2/+2
Pointer "pBuf" returned from "fgets(buf, 256, stream)" is never used Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01XDefaultOMIF.c: Fix memory leaks in get_font_nameAlan Coopersmith1-8/+2
Instead of copying the value returned by get_prop_name and then releasing it, directly use the return value of get_prop_name, which allocates memory for the name. If get_prop_name returns NULL, continue on to XFreeFont to release the font before returning the NULL via the normal function return. Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-02-01config: comment, minor upgrade, quote and layout configure.acGaetan Nadon1-54/+54
Group statements per section as per Autoconf standard layout Quote statements where appropriate. Autoconf recommends not using dnl instead of # for comments Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters. Remove redundant AC_CANONICAL_HOST included in XORG_DEFAULT_OPTIONS This helps automated maintenance and release activities. Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-31Comparing array against NULL is not useful "&xkb->server->vmods != NULL"Erkki Seppälä1-1/+1
Removed superfluous comparison. Reviewed-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
2011-01-31Variable "entry" tracked as NULL was dereferenced.Erkki Seppälä1-1/+1
Check entry for non-nullness before dereferencing it Reviewed-by: Dirk Wallenstein <halsmit@t-online.de> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
2011-01-31Dereferencing possibly NULL "str" in call to function "memcpy" (Deref ↵Erkki Seppälä1-0/+2
assumed on the basis of 'nonnull' parameter attribute.) If _XkbGetReadBufferPtr returns NULL, goto BAILOUT Reviewed-by: Dirk Wallenstein <halsmit@t-online.de> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
2011-01-31Using freed pointer "e"Erkki Seppälä1-2/+2
Reordered code to first to do the comparison and then to release data Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
2011-01-28Remove <literal> tags from compose-chart.pl so pdf building doesn't die on ↵Matt Dew1-1/+1
soft-hyphens. Signed-off-by: Matt Dew <marcoz@osource.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-28config: replace deprecated AC_HELP_STRING with AS_HELP_STRINGGaetan Nadon1-11/+11
This silences an Automake warning. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-28config: remove unrequired AC_HEADER_STDCGaetan Nadon1-1/+0
Autoconf says: "This macro is obsolescent, as current systems have conforming header files. New programs need not use this macro".
2011-01-19config: Use correct AC_CONFIG_HEADERS macroAlan Coopersmith1-2/+1
Replaces obsolete AM_CONFIG_HEADER and undocumented AC_CONFIG_HEADER Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca> Reviewed-by: Dan Nicholson <dbn.lists@gmail.com>
2011-01-18config: remove AC_PROG_CC as it overrides AC_PROG_C_C99Alan Coopersmith1-1/+0
XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls AC_PROG_C_C99. This sets gcc with -std=gnu99. If AC_PROG_CC macro is called afterwards, it resets CC to gcc. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-18Update to xf86bigfontproto >= 1.2.0 header nameAlan Coopersmith2-4/+2
Clears compile-time warning of: "X11/extensions/xf86bigfstr.h", line 1: #warning: "xf86bigfstr.h is obsolete and may be removed in the future." "X11/extensions/xf86bigfstr.h", line 2: #warning: "include <X11/extensions/xf86bigfproto.h> for the protocol defines." Requires xf86bigfontproto >= 1.2.0 if --disable-xf86bigfont is not passed to configure. Also removes unnecessary AC_SUBST of BIGFONT_CFLAGS & BIGFONT_LIBS that PKG_CHECK_MODULES does automatically Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Julien Cristau <jcristau@debian.org>
2011-01-11libX11 1.4.1Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-01-03Initialize event typePauli Nieminen1-0/+2
If we receive unsupported event closing connection triggers valgrind error. ==12017== Conditional jump or move depends on uninitialised value(s) ==12017== at 0x487D454: _XFreeDisplayStructure (OpenDis.c:607) ==12017== by 0x486857B: XCloseDisplay (ClDisplay.c:72) *snip* ==12017== Uninitialised value was created by a heap allocation ==12017== at 0x4834C48: malloc (vg_replace_malloc.c:236) ==12017== by 0x4894147: _XEnq (XlibInt.c:877) ==12017== by 0x4891BF3: handle_response (xcb_io.c:335) ==12017== by 0x4892263: _XReply (xcb_io.c:626) *snip* Problem is that XFreeDisplaySturture is checking for qelt->event.type == GenericEvent while _XUnknownWireEvent doesn't store the type. Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
2010-12-28specs: convert images from gif to svg format.Fernando Carrijo52-42/+16729
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-12-22Events: Store event cookie when dequeuing eventPhilipp Reh2-0/+2
When we dequeue an event in XCheckTypedEvent or XCheckTypedWindowEvent, make sure to store the corresponding cookie too. Signed-off-by: Philipp Reh <sefi@s-e-f-i.de> Reviewed-by: Daniel Stone <daniel@fooishbar.org>
2010-12-21Revert "Mark atom names argument to XInternAtoms as const"Alan Coopersmith4-9/+9
This reverts commit c8701115462b482d99ecff24d9de0f2806084ba5. The constification of a pointer to a pointer caused unexpected issues, and xorg-devel was unable to come up with a clean, safe, reasonable way to handle them, so we're chalking this up for now as yet another mistake in the Xlib API definition we'll be living with. See https://bugs.freedesktop.org/show_bug.cgi?id=32098 for details. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-12-21specs/XKB: make acknowlegement section <preface> instead of <chapter>Alan Coopersmith1-2/+2
Fixes numbering of actual chapters to match their filenames and to make the table/figure numbering match the references in the text. Reported-by: jelmd on freenode irc Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-12-21Add XKBlib spec images to dist_spec_DATA for distribution & installationAlan Coopersmith1-1/+22
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
2010-11-30specs: convert XKBlib spec from Framemaker to DocBook.xmlMatt Dew49-1/+35173
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-11-24Mark atom names argument to XInternAtoms as constAlan Coopersmith4-9/+9
Updates code & docs for XInternAtoms. The single atom name argument to XInternAtom was already const char * in the code, but not the docs, so updated it in the docs too. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
2010-11-21libX11 1.4.0Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-11-10config: Check host string when deciding architecture to build forDan Nicholson1-1/+1
When checking for the OS/2 platform, $target_os is used. However, unless building a cross compiler, the $host* strings contain the platform details for the build system. See: http://www.gnu.org/software/automake/manual/automake.html#Cross_002dCompilation $host_os is already being used to determine the transport and threading options. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Reviewed-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-11-10config: Fix architecture check for OS/2 to skip nios2 cpuDan Nicholson1-2/+2
The OS/2 platform requires some utility functions as well as having a non-32 bit wchar_t. Fix the configure check so that it doesn't also affect the nios2 cpu, which wouldn't influence these operating system issues. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Tested-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-11-09config: HTML file generation: use the installed copy of xorg.cssGaetan Nadon2-6/+4
Currenlty the xorg.css file is copied in each location where a DocBook/XML file resides. This produces about 70 copies in the $(docdir) install tree. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-10-29libX11 1.3.99.903 (1.4.0 RC3)Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-29Require xorg-macros 1.11 now that it is releasedAlan Coopersmith1-3/+3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-29docs: Disable fop documentation by defaultDan Nicholson1-1/+1
fop is used to generate the pdf and ps formats of the documentation. This can significantly slow down the build, especially when creating all the compose key charts. Since few people probably want the full set of doc formats, set the default to 'no'. The default parameter for XORG_WITH_FOP is only available in recent macros. Users generating configure from older macros will just get 'auto' as the default. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Reviewed-by: Gaetan Nadon <memsize@videotron.ca> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-28Add C.UTF-8 and C.ASCII locale aliasesJon TURNEY1-0/+2
Add C.UTF-8 locale as an alias for en_US.UTF-8 Add C.ASCII locale as an alias for C (C.UTF-8 is the default locale for cygwin. It also exists in debian, although I don't think it's intended for use by humans.) Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk> Acked-by: Julien Cristau <jcristau@debian.org> Reviewed-by: James Cloos <cloos@jhcloos.com>
2010-10-10docs: Remove directory prerequisites from make rulesDan Nicholson2-11/+4
Make expects prerequisites to be files with valid timestamps, and directories are treated as always being out of date. Thus, any targets depending on directories will always be rebuilt. Instead, the doc rules are changed to always create the target's leading directory. This should prevent the documentation from being rebuilt when "make install" is run. Signed-off-by: Dan Nicholson <dbn.lists@gmail.com> Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-26Add an "X11_" string to header guards to avoid possible collisionJeremy Huddleston11-33/+33
This addresses a build failure which can result from <X11/Xlocale.h> and <xlocale.h> being included in the same code since they both used the same _XLOCALE_H_ protection. Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2010-09-21libX11 1.3.99.902 (1.4.0 RC2)Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-21Bug 19379 - Provide docs with overview of all compose key combinationsAlan Coopersmith6-8/+436
Adds compose-chart.pl to generate DocBook/XML documents listing compose keys, and Makefile rules to generate HTML & PDF output from them if xmlto is present. https://bugs.freedesktop.org/show_bug.cgi?id=19379 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mikhail Gusarov <dottedmag@dottedmag.net> Reviewed-by: James Cloos <cloos@jhcloos.com> Tested-by: Gaetan Nadon <memsize@videotron.ca>
2010-09-21Make locale data build non-recursive / parallelizableAlan Coopersmith64-256/+28
On a 4 core CPU with gmake -j 16 the nls subdir builds in half the time, plus this simplifies the next set of changes. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mikhail Gusarov <dottedmag@dottedmag.net> Reviewed-by: James Cloos <cloos@jhcloos.com> Tested-by: Gaetan Nadon <memsize@videotron.ca>
2010-09-17config: remove man page suffix from bottom summaryGaetan Nadon1-1/+0
The man page suffix is the same for all libraries on a given platform and is not configurable. It should have been removed in commit 09edc6de6. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-09-17config: remove unhelpful comment in .gitignoreGaetan Nadon1-1/+0
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2010-09-14Zero buffer data in BufAlloc()Adam Jackson1-1/+1
Inspired by a pattern in NoMachine's NX. Consistently zeroed buffers compress better with ssh and friends. Note that you'll need to rebuild all your protocol libraries to take advantage of this. Signed-off-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-13Revert “Dolt-ify"James Cloos3-187/+0
Libtool’s is now sufficiently fast that DOLT is no longer worth the bother, even on those few systems where is works. This reverts commit 3e9afd501e40d76040635bd9a3045bcaf5a03b60 and part of commit d31e644c65c52828ea3e7abd94a8cf9aee12265c. It conflicted with commit f6a4fd0c7615684d08e848245849dea4017a5214 which moved dolt from configure.ac to m4/dolt.m4. And it addresses: http://bugs.freedesktop.org/show_bug.cgi?id=28188 Signed-off-by: James Cloos <cloos@jhcloos.com>
2010-09-09XIM spec title page minor formatting cleanupAlan Coopersmith1-18/+12
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-09Bug 29773: aliases for nb_NO.utf8 and nn_NO.utf8Jens Petersen1-0/+2
<https://bugs.freedesktop.org/show_bug.cgi?id=29773> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-03Sun's copyrights are now owned by OracleAlan Coopersmith221-222/+222
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-09-03libX11 1.3.99.901 (1.4.0 RC1)Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-08-29libX11/nls compose tables, add LATIN CAPITAL LETTER SHARP SJeroen Hoek1-0/+1
Add LATIN CAPITAL LETTER SHARP S (See https://bugs.freedesktop.org/show_bug.cgi?id=29448 for rationale) Signed-off-by: James Cloos <cloos@jhcloos.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-10 00:48:24 +0000