summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2017-08-23 10:27:11 +0200
committerJuan Quintela <quintela@redhat.com>2017-09-05 22:34:40 +0200
commitc18aaeb69072b74cb0a66e6638fcb14837c7cd3a (patch)
tree7daccce9d1f538d76d9ff9a35c065f2c21567ea7 /tests
parente3ff9f0e57472e6411dc446b41789cbd9e2cf887 (diff)
tests: Make vmgenid test compile
Just make sure that nr_tables is size_t not int. Once there, do the assert in the right place and be sure that we don't have a division by zero. Suggested-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: Juan Quintela <quintela@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com> -- Drop the s/g_new0/g_malloc0/ change. Avoid division by zero with assert (danp)
Diffstat (limited to 'tests')
-rw-r--r--tests/vmgenid-test.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c
index 3d5c1c3615..918c82c82a 100644
--- a/tests/vmgenid-test.c
+++ b/tests/vmgenid-test.c
@@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(void)
AcpiRsdpDescriptor rsdp_table;
uint32_t rsdt;
AcpiRsdtDescriptorRev1 rsdt_table;
- int tables_nr;
+ size_t tables_nr;
uint32_t *tables;
AcpiTableHeader ssdt_table;
VgidTable vgid_table;
@@ -62,9 +62,9 @@ static uint32_t acpi_find_vgia(void)
ACPI_ASSERT_CMP(rsdt_table.signature, "RSDT");
/* compute the table entries in rsdt */
+ g_assert_cmpint(rsdt_table.length, >, sizeof(AcpiRsdtDescriptorRev1));
tables_nr = (rsdt_table.length - sizeof(AcpiRsdtDescriptorRev1)) /
sizeof(uint32_t);
- g_assert_cmpint(tables_nr, >, 0);
/* get the addresses of the tables pointed by rsdt */
tables = g_new0(uint32_t, tables_nr);