diff options
| author | Matt Turner <mattst88@gmail.com> | 2014-12-19 21:35:56 -0800 |
|---|---|---|
| committer | Matt Turner <mattst88@gmail.com> | 2015-02-10 17:47:37 -0800 |
| commit | 3d581f99963dea7e93a2f8fd819410da02c1cb7f (patch) | |
| tree | b30d021ab257b1211701883b2afbcc3ba8115b26 | |
| parent | 5b29b2922afe2b8167a589fc2896a071fc85b693 (diff) | |
i965/vec4: Emit MADs from (x + -(y * z)).
Same as commit c4fab711 to the fs backend.
total instructions in shared programs: 5945998 -> 5945788 (-0.00%)
instructions in affected programs: 74665 -> 74455 (-0.28%)
helped: 399
HURT: 180
It hurts some programs because we make no attempts in the vec4 backend
to avoid MADs if they have constant (or vector uniform) arguments.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
| -rw-r--r-- | src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index 432c2182d3..2a988d0a0c 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp @@ -1161,10 +1161,21 @@ vec4_visitor::try_emit_mad(ir_expression *ir) ir_rvalue *nonmul = ir->operands[1]; ir_expression *mul = ir->operands[0]->as_expression(); + bool mul_negate = false; + if (mul && mul->operation == ir_unop_neg) { + mul = mul->operands[0]->as_expression(); + mul_negate = true; + } + if (!mul || mul->operation != ir_binop_mul) { nonmul = ir->operands[0]; mul = ir->operands[1]->as_expression(); + if (mul && mul->operation == ir_unop_neg) { + mul = mul->operands[0]->as_expression(); + mul_negate = true; + } + if (!mul || mul->operation != ir_binop_mul) return false; } @@ -1174,6 +1185,7 @@ vec4_visitor::try_emit_mad(ir_expression *ir) mul->operands[0]->accept(this); src_reg src1 = fix_3src_operand(this->result); + src1.negate ^= mul_negate; mul->operands[1]->accept(this); src_reg src2 = fix_3src_operand(this->result); |