From 4546cbf1cec10891319c7049db15e64c3d1c0169 Mon Sep 17 00:00:00 2001 From: Julien Cristau Date: Wed, 2 Mar 2016 21:28:20 +0100 Subject: xfixes: avoid double free if AddResource fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pChc is already freed through CursorFreeHideCount → deleteCursorHideCount. Signed-off-by: Julien Cristau --- xfixes/cursor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xfixes/cursor.c b/xfixes/cursor.c index 5619aad2e..10f9b2346 100644 --- a/xfixes/cursor.c +++ b/xfixes/cursor.c @@ -774,10 +774,8 @@ createCursorHideCount(ClientPtr pClient, ScreenPtr pScreen) * Create a resource for this element so it can be deleted * when the client goes away. */ - if (!AddResource(pChc->resource, CursorHideCountType, (void *) pChc)) { - free(pChc); + if (!AddResource(pChc->resource, CursorHideCountType, (void *) pChc)) return BadAlloc; - } return Success; } -- cgit v1.2.3