diff options
author | Gwenole Beauchesne <gwenole.beauchesne@intel.com> | 2014-05-06 13:08:28 +0200 |
---|---|---|
committer | Gwenole Beauchesne <gwenole.beauchesne@intel.com> | 2014-06-06 14:32:41 +0200 |
commit | 77af916b44da04e3424490506a7e5bef39c80c7c (patch) | |
tree | 452a99db17b83b68e9964a7e5a10e124f5808a47 | |
parent | 510b271f912afb35edac1d3fb39354ee98b01711 (diff) |
decoder: h264: don't deallocate surface storage of older frames.
Drop the optimization whereby surfaces that are no longer marked as
reference and that were already displayed are to be destroyed. This
is wrong mainly for two reasons:
1. The surface was displayed... once but it may still be needed for
subsequent operations like displaying it again, using it for a
transcode pipeline (encode) for instance, etc.
2. The new set of ReferenceFrames[] correspond to the active set of
reference frames used for decoding the current slice. In presence
of Multiview Coding (MVC), that could correspond to the current
view, in view order index, but the surface may still be needed
for decoding the next view with the same view_id, while also
decoding other views with another set of reference frames for them.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
-rw-r--r-- | src/i965_decoder_utils.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/i965_decoder_utils.c b/src/i965_decoder_utils.c index 360e8a7..a90148c 100644 --- a/src/i965_decoder_utils.c +++ b/src/i965_decoder_utils.c @@ -451,15 +451,6 @@ intel_update_avc_frame_store_index(VADriverContextP ctx, /* remove it from the internal DPB */ if (!found) { - struct object_surface *obj_surface = frame_store[i].obj_surface; - - obj_surface->flags &= ~SURFACE_REFERENCED; - - if ((obj_surface->flags & SURFACE_ALL_MASK) == SURFACE_DISPLAYED) { - obj_surface->flags &= ~SURFACE_REF_DIS_MASK; - i965_destroy_surface_storage(obj_surface); - } - frame_store[i].surface_id = VA_INVALID_ID; frame_store[i].frame_store_id = -1; frame_store[i].obj_surface = NULL; |