summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarta Lofstedt <marta.lofstedt@intel.com>2015-10-29 14:33:00 +0100
committerTapani Pälli <tapani.palli@intel.com>2015-11-04 07:07:39 +0200
commit5723460fe7279714a1dbe693481117d1ff622bb0 (patch)
treeeb6919513978bc5f6548ec8efcab52e43ba7d092
parentf8a3bd463b072efcf01aa7dff6d42c691b3959ef (diff)
arb_draw_indirect: Adopt to INVALID_VALUE on unaligned DrawIndirect
In Mesa commit: 2c91e086563541271668f9ea6ca58689c0c97d44 It was concluded that Mesa should follow the definition from OpenGL 4.4 specification, section 10.4 and OpenGL ES 3.1 section 10.5: "An INVALID_VALUE error is generated if indirect is not a multiple of the size, in basic machine units, of uint." Previous definitions called for an INVALID_OPERATION to be generated. Signed-off-by: Marta Lofstedt <marta.lofstedt@linux.intel.com>
-rw-r--r--tests/spec/arb_draw_indirect/api-errors.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/spec/arb_draw_indirect/api-errors.c b/tests/spec/arb_draw_indirect/api-errors.c
index dfa93e48a..7f25ea917 100644
--- a/tests/spec/arb_draw_indirect/api-errors.c
+++ b/tests/spec/arb_draw_indirect/api-errors.c
@@ -161,7 +161,7 @@ check_draw_beyond_end(void)
static bool
check_draw_misaligned(void)
{
- /* An INVALID_OPERATION error is generated
+ /* An INVALID_VALUE error is generated
* .. or if <indirect> is not word aligned.
*/
@@ -172,7 +172,7 @@ check_draw_misaligned(void)
glDrawArraysIndirect(GL_TRIANGLES, (GLvoid const *)1); /* misaligned */
- if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+ if (!piglit_check_gl_error(GL_INVALID_VALUE))
return false;
return true;