diff options
| author | Frediano Ziglio <fziglio@redhat.com> | 2019-02-09 17:02:01 +0000 |
|---|---|---|
| committer | Frediano Ziglio <freddy77@gmail.com> | 2023-11-22 07:39:22 +0000 |
| commit | a51f6537780af6d51c36e7e1ca465bdcada469f6 (patch) | |
| tree | 02a83f499e230b61b180ebdc954b977149c4788b | |
| parent | 592eceda9dc54ed3eb6acf1b5333df116028cd96 (diff) | |
COMMENTS some considerations, maybe some can be simplified
| -rw-r--r-- | server/char-device.cpp | 1 | ||||
| -rw-r--r-- | server/reds.cpp | 5 |
2 files changed, 5 insertions, 1 deletions
diff --git a/server/char-device.cpp b/server/char-device.cpp index 1be96c06..0ecb995b 100644 --- a/server/char-device.cpp +++ b/server/char-device.cpp @@ -749,6 +749,7 @@ void RedCharDevice::migrate_data_marshall_empty(SpiceMarshaller *m) mig_data = reinterpret_cast<SpiceMigrateDataCharDevice *>( spice_marshaller_reserve_space(m, sizeof(*mig_data))); memset(mig_data, 0, sizeof(*mig_data)); + // XXX to LE ?? mig_data->version = SPICE_MIGRATE_DATA_CHAR_DEVICE_VERSION; mig_data->connected = FALSE; } diff --git a/server/reds.cpp b/server/reds.cpp index 101e0312..73531212 100644 --- a/server/reds.cpp +++ b/server/reds.cpp @@ -662,7 +662,9 @@ void reds_on_main_mouse_mode_request(RedsState *reds, void *message, size_t size void reds_marshall_migrate_data(RedsState *reds, SpiceMarshaller *m) { - // XXX + // XXX why asking to the device to marshall? It the VDIPort storing some data about migration? + // XXX the structure holds just information for the agent, so make sense that MCC calls + // VDIPort directly! Also make sense other part of this function in VDIPort vdi_port_marshall_migrate_data(reds->agent_dev.get(), m); } @@ -2483,6 +2485,7 @@ static int spice_server_char_device_remove_interface(RedsState *reds, SpiceBaseI g_return_val_if_fail(char_device == vdagent, -1); if (vdagent) { reds_agent_remove(reds); + // XXX is this not done above? check where vdagent and agent_dev are set reds->agent_dev->reset_dev_instance(nullptr); } } |