From f8e0516ba7f6dcc8b27e02e80fd6f3d23a03e816 Mon Sep 17 00:00:00 2001 From: Francois Gouget Date: Wed, 23 Nov 2016 07:09:28 +0100 Subject: build-sys: Enable deprecation warnings instead of ignoring them entirely For Spice-gtk most deprecation issues come from changes outside Spice (GLib) and thus should not be treated as errors to not break compilation for users who have newer third-party libraries. However they must be visible otherwise Spice developers will not be aware of them and thus will not fix them before breakage happens. Signed-off-by: Francois Gouget Acked-by: Christophe Fergeau --- m4/spice-compile-warnings.m4 | 2 +- src/controller/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4 index 533bac6..dfa88fe 100644 --- a/m4/spice-compile-warnings.m4 +++ b/m4/spice-compile-warnings.m4 @@ -85,7 +85,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[ gl_WARN_ADD([-Wno-format-nonliteral]) # We use some deprecated functions to avoid #ifdef hell while maintaining # compat with older gtk / glib versions - gl_WARN_ADD([-Wno-deprecated-declarations]) + gl_WARN_ADD([-Wno-error=deprecated-declarations]) diff --git a/src/controller/Makefile.am b/src/controller/Makefile.am index fb56986..c68373c 100644 --- a/src/controller/Makefile.am +++ b/src/controller/Makefile.am @@ -1,5 +1,7 @@ NULL = +# FIXME: We need to disable the deprecation warnings until valac stops +# generating code that uses the deprecated GSimpleAsyncResult class. AM_CPPFLAGS = \ -DG_LOG_DOMAIN=\"GSpiceController\" \ $(GIO_CFLAGS) \ -- cgit v1.2.3