summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEamon Walsh <ewalsh@tycho.nsa.gov>2009-09-22 13:13:03 -0700
committerKeith Packard <keithp@keithp.com>2009-10-27 14:30:16 -0700
commit250ce150b229bc384584b310e79658a41486321e (patch)
tree3adeb83759274f99a1e468fc482df707029477de
parentf9e6ee70f32b6d86fb272e2824deb7309b7ea7ce (diff)
xace: Relax permissions on XkbGetState from Read to Getattr.
This request is used to get the current keyboard group and is called from GTK. It does not return an actual keymap (aside from modifiers) so it should be safe to relax the permission on it. However it does return button state information which should be controlled through a separate pointer Read check. Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov> (cherry picked from commit c4ffce4dc84a0a9d134a59b7e7765c99ed767e53) Signed-off-by: Keith Packard <keithp@keithp.com>
-rw-r--r--xkb/xkb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 4ff2d5fef..a62db7b4d 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -553,7 +553,7 @@ ProcXkbGetState(ClientPtr client)
if (!(client->xkbClientFlags&_XkbClientInitialized))
return BadAccess;
- CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixReadAccess);
+ CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixGetAttrAccess);
xkb= &dev->key->xkbInfo->state;
bzero(&rep,sizeof(xkbGetStateReply));