| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Simply keep reading from the fifos in reasonably sized chunks.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
This avoids compilation errors with -Werror on 32 bit systems and is
more correct than a direct cast.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
We don't need to update the screen when we use a temporary or
offscreen pixmap.
|
|
This prevents the fallback from calling prepare_access
against the whole screen, which in turn keeps us from
transmitting the whole screen more than necessary.
|
|
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
|
|
We will put auto session related items in that directory.
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
|
|
|
|
|
|
As of commit f73ca7e4cc090772652611a4e2b8b95ae64319bc, you can now
disable the regular port by specifying 0. This change to the Xspice
script permits us to take advantage of that change.
|
|
is not disabled.
This fixes a bug where Xspice had to listen on two ports, even in an
SSL only configuration.
|
|
Also revise the expression of the default value to be consistent.
|
|
Since the introduction of vdagent support in commit
294daff7ea930f338ec6d77ec3465b6f727c168e, the
SpiceAgentMouse setting has not really operated correctly.
That is, if SpiceVdagentEnabled was true, the value
of SpiceAgentMouse was overridden.
This patch corrects that.
It also shifts the default; that matches qemu, and effectively
preserves the current default behavior.
|
|
Otherwise, you constantly spin loop, getting a return code of 0,
and pegging CPU usage at 100%.
|
|
actually connects and disconnects.
This means that we do not attempt to use agent mouse
mode if there is no connected agent.
It fixes a bug which would occur if an agent disconnected
after session startup which would result in having no
useful mouse.
|
|
Also shift to libspiceccid_la_CFLAGS.
|
|
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
Otherwise they override Spice server's real builtin defaults, the Xorg configuration file settings, and even the XSPICE_XXX environment variables.
For instance, without this patch calling Xspice _without_ the '--streaming-video' option forces this setting to 'filter', overriding the XSPICE_STREAMING_VIDEO environment variable and the SpiceStreamingVideo spiceqxl.xorg.conf setting.
Note that this does not change the option defaults (the Xspice ones matched the spice server ones).
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
Issue a warning for invalid values but treat them as TRUE for backward compatibility.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
|
|
Some compiler warnings for example:
uxa-glyphs.c:1045: warning: ‘width’ may be used uninitialized in this function
uxa-glyphs.c:1045: warning: ‘height’ may be used uninitialized in this function
uxa-render.c:1090: warning: ‘xDst_copy’ may be used uninitialized in this function
uxa-render.c:1090: warning: ‘yDst_copy’ may be used uninitialized in this function
I think these can never actually happen as the code protects use of
those uninitialized variables, but I'd not "argue" with the compiler.
|
|
|
|
spice-server now ignores this mm_time value and sets it itself as it
maintains its own timer (see spice-server commit c541d7e2 'Remove guest
side video time-stamping')
|
|
|
|
Xorg 1.18 stopped exporting some xfont related symbols in its
headers/shared libraries, which causes QXL to fail to build:
uxa-damage.c:947:5: error: implicit declaration of function 'QueryGlyphExtents' [-Werror=implicit-function-declaration]
QueryGlyphExtents(font, charinfo, n, &extents);
The missing definition can be found in xfont, so this commit addes the
needed configure.ac checks and includes.
Note that dixfontstr.h must be included before the xfont headers or this
will cause compile-time warnings on older Xorg versions (eg 1.17)
|
|
These headers come from /usr/include/xorg/ so it's clearer if they are
included using <>. While at it, I've reordered them alphabetically.
|
|
When KMS is enabled, the mm_time value of a QXLDrawable is undefined.
This results in severe synchronization problems. This patch sets it to
zero to force the spice-server to use the local clock.
|
|
This enables a kill of an Xorg process to propagate further.
Without this, the read masks would be set, and we could end up
blocking in an accept() call and not exiting from the signal.
|
|
The pScrn->currentMode is the resolution of the first monitor,
not the resolution of the whole virtual screen.
This fixes restarting X when several monitors are enabled.
|
|
The pScrn->virtualX/Y are set after drmmode_pre_init(), use that
resolution instead of hard-coded 1024x768.
This fixes rendering glitches when restarting X server with
different primary size than actual monitor modes.
|
|
This ensures better portability as some arches (eg aarch64) don't have
outb.
On linux pci_io_* try to open the sysfs map file corresponding to the
I/O port range, which the kernel translates arch-appropriately. If
there is no such file then it'll try to use port instructions if that's
a thing the architecture has. So you only need one path, pciaccess
exists to get the portability right for you.
https://bugzilla.redhat.com/show_bug.cgi?id=1201877
|
|
|
|
|
|
|
|
No need for hardcoded variant here.
|
|
|
|
While looking for leaks, I realized that the image cache looks
quite suspicious.
Not only it leaks when qxl_drop_image_cache() is called,
since all the allocated image_info_t references are lost.
But it is also useless: "The name implies it's a cache of some
sort, but data is only added to it. The only time data is looked up in
that cache is when it needs to be destroyed, and this is not done
correctly and causes leaks. Since the cached data is never used and
since it's leaky, it's better to remove it altogether"
|
|
qxl_load_cursor_argb() owns 2 references on the cursor_bo it creates:
- one from the call to bo_alloc()
- the second from a call to bo_output_bo_reloc()
qxl_garbage_collect() release one of these refs, but the other one is
never released, so ARGB cursor bos are leaked. This can cause out of
memory issues, for example when running EL6 anaconda installer on a 2TB
disk image (see bug https://bugzilla.redhat.com/show_bug.cgi?id=1199355
).
This commit release the extra ref right after calling push_cursor().
This is similar to what is done in qxl_surface_put_image().
|
|
Make sure they are indented with tabs and aligned.
|
|
This file needs to be listed in Makefile.am otherwise it will not be
added to the tarballs make dist generates.
|
|
|
|
Also add a message for apdus that come in while a reader is inactive.
Remove an obviously unnecessary if stanza.
|
|
Instead of copying /usr/share/X11/xkb
|
|
This helps build on a RHEL-6 machine
|
|
This fixes the following compiler warning.
spiceqxl_vdagent.c:49: warning: declaration of ‘read’ shadows a global declaration
/usr/include/unistd.h:357: warning: shadowed declaration is here
|
|
This fixes the following compiler warning.
spiceqxl_audio.c: In function ‘playback_dir_changed’:
spiceqxl_audio.c:386: warning: declaration of ‘index’ shadows a global declaration
|
|
From: "Charles Ricketts <githlar@gmail.com>"
|
|
|
|
Also added a check for the case variables are uninitialized (or
when the executables are not found and which returns None)
|
|
Also handle None parameter case.
|
|
This is done by creating a Unix domain socket to which smartcard
messages are transferred, using the vscard protocol.
A further system library, spiceccid, is used to provide an interface into
pcsc-lite, specifically the pcsc-lite daemon, so that regular Unix applications
can access the passed through smartcard information.
Signed-off-by: Jeremy White <jwhite@codeweavers.com>
|
