diff options
| author | Michel Dänzer <michel.daenzer@amd.com> | 2016-02-25 16:43:48 +0900 |
|---|---|---|
| committer | Michel Dänzer <michel@daenzer.net> | 2016-02-25 16:43:48 +0900 |
| commit | 3989766edde85d1abe7024577b98fc9b007bc02a (patch) | |
| tree | 4b97aced5db66e26ee5ca7ea584b0d34e6971c9f | |
| parent | 7bc089ee9740a3ef91f16e36786d8ed64e165acd (diff) | |
drm_queue: Don't abort events immediately from radeon_drm_abort_client
Keep them around until the DRM event arrives, but then call the abort
functions instead of the handler functions.
This is a prerequisite for the following fix.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | src/radeon_drm_queue.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/src/radeon_drm_queue.c b/src/radeon_drm_queue.c index 5e54ef8b..a50a1fde 100644 --- a/src/radeon_drm_queue.c +++ b/src/radeon_drm_queue.c @@ -64,8 +64,12 @@ radeon_drm_queue_handler(int fd, unsigned int frame, unsigned int sec, xorg_list_for_each_entry_safe(e, tmp, &radeon_drm_queue, list) { if (e == user_data) { xorg_list_del(&e->list); - e->handler(e->scrn, frame, - (uint64_t)sec * 1000000 + usec, e->data); + if (e->handler) + e->handler(e->scrn, frame, + (uint64_t)sec * 1000000 + usec, + e->data); + else + e->abort(e->scrn, e->data); free(e); break; } @@ -115,15 +119,19 @@ radeon_drm_abort_one(struct radeon_drm_queue_entry *e) /* * Abort drm queue entries for a client + * + * NOTE: This keeps the entries in the list until the DRM event arrives, + * but then it calls the abort functions instead of the handler + * functions. */ void radeon_drm_abort_client(ClientPtr client) { - struct radeon_drm_queue_entry *e, *tmp; + struct radeon_drm_queue_entry *e; - xorg_list_for_each_entry_safe(e, tmp, &radeon_drm_queue, list) { + xorg_list_for_each_entry(e, &radeon_drm_queue, list) { if (e->client == client) - radeon_drm_abort_one(e); + e->handler = NULL; } } |