summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Larsson <alexl@redhat.com>2015-08-31 09:07:36 +0200
committerAlexander Larsson <alexl@redhat.com>2015-08-31 09:07:36 +0200
commit188474b4ea785464738fef643b46a4b8f8823b02 (patch)
tree50ee0bf3b3d26a03c77b8f551a2239c26d6ec6ee
parentd9d7af5b7ffc03902874887ca7bca0c9d0dc5703 (diff)
Add patch to make make not crash if ttyname fails.
-rw-r--r--meta-freedesktop/recipes-devtools/make/make/make-handle-ttyname-fail.patch56
-rw-r--r--meta-freedesktop/recipes-devtools/make/make_4.1.bbappend4
2 files changed, 60 insertions, 0 deletions
diff --git a/meta-freedesktop/recipes-devtools/make/make/make-handle-ttyname-fail.patch b/meta-freedesktop/recipes-devtools/make/make/make-handle-ttyname-fail.patch
new file mode 100644
index 0000000..b96d24f
--- /dev/null
+++ b/meta-freedesktop/recipes-devtools/make/make/make-handle-ttyname-fail.patch
@@ -0,0 +1,56 @@
+From 292da6f6867b75a5af7ddbb639a1feae022f438f Mon Sep 17 00:00:00 2001
+From: Paul Smith <psmith@gnu.org>
+Date: Mon, 20 Oct 2014 01:54:56 -0400
+Subject: [PATCH] * main.c (main): [SV 43434] Handle NULL returns from
+ ttyname().
+
+---
+ main.c | 15 ++++++++++-----
+ makeint.h | 3 ++-
+ 2 files changed, 12 insertions(+), 6 deletions(-)
+
+diff --git a/main.c b/main.c
+index b2d169c..0cdb8a8 100644
+--- a/main.c
++++ b/main.c
+@@ -1429,13 +1429,18 @@ main (int argc, char **argv, char **envp)
+ #ifdef HAVE_ISATTY
+ if (isatty (fileno (stdout)))
+ if (! lookup_variable (STRING_SIZE_TUPLE ("MAKE_TERMOUT")))
+- define_variable_cname ("MAKE_TERMOUT", TTYNAME (fileno (stdout)),
+- o_default, 0)->export = v_export;
+-
++ {
++ const char *tty = TTYNAME (fileno (stdout));
++ define_variable_cname ("MAKE_TERMOUT", tty ? tty : DEFAULT_TTYNAME,
++ o_default, 0)->export = v_export;
++ }
+ if (isatty (fileno (stderr)))
+ if (! lookup_variable (STRING_SIZE_TUPLE ("MAKE_TERMERR")))
+- define_variable_cname ("MAKE_TERMERR", TTYNAME (fileno (stderr)),
+- o_default, 0)->export = v_export;
++ {
++ const char *tty = TTYNAME (fileno (stderr));
++ define_variable_cname ("MAKE_TERMERR", tty ? tty : DEFAULT_TTYNAME,
++ o_default, 0)->export = v_export;
++ }
+ #endif
+
+ /* Reset in case the switches changed our minds. */
+diff --git a/makeint.h b/makeint.h
+index 6223936..2009f41 100644
+--- a/makeint.h
++++ b/makeint.h
+@@ -436,10 +436,11 @@ extern struct rlimit stack_limit;
+ /* The number of bytes needed to represent the largest integer as a string. */
+ #define INTSTR_LENGTH CSTRLEN ("18446744073709551616")
+
++#define DEFAULT_TTYNAME "true"
+ #ifdef HAVE_TTYNAME
+ # define TTYNAME(_f) ttyname (_f)
+ #else
+-# define TTYNAME(_f) "true"
++# define TTYNAME(_f) DEFAULT_TTYNAME
+ #endif
+
+
diff --git a/meta-freedesktop/recipes-devtools/make/make_4.1.bbappend b/meta-freedesktop/recipes-devtools/make/make_4.1.bbappend
new file mode 100644
index 0000000..0b8dd4b
--- /dev/null
+++ b/meta-freedesktop/recipes-devtools/make/make_4.1.bbappend
@@ -0,0 +1,4 @@
+FILESEXTRAPATHS_append := ":${THISDIR}/${PN}"
+SRC_URI += "\
+ file://make-handle-ttyname-fail.patch \
+ "