Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
after_script ignores any exit status so we can't actually fail the job here
Fixes #573
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 3eb428ef568808e4af115a64531a21fa28ed8dd2)
|
|
The default setting makes the "Dell Latitude E5510 TouchPad" too sensitive and
consequently difficult to use.
Note that the the size of the TouchPad is detected to be higher than it is
(the side-bars are half out of the TouchPad), see
https://github.com/systemd/systemd/pull/18493 for the hwdb overrides for this
device.
Signed-off-by: Gablegritule <guillet.gabriel@laposte.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 9f594664d91979d570be803b6656c2494464ad3b)
|
|
The touchpad for the Dell Inspiron 15R N5110 was too sensitive with default
settings, leading to excessive movement when lifting finger.
Fixes #565
Signed-off-by: Gary Wolfe <avidgamefan@yahoo.com>
(cherry picked from commit 3f15bc3985bbfa73206119d3bd4b55e14f5f6041)
|
|
This touchpad is a true pressurepad and the pressure axis gives us physical
pressure down. Using it as contact size gives flaky touch detection, so let's
just disable the axis until we do something with that value.
Fixes #562
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 53595cb23262f61005c4b24a19936dabac12159e)
|
|
Signed-off-by: Blaž Hrastnik <blaz@mxxn.io>
(cherry picked from commit aec8e0b4ef00f46e964a0053b98638fa72701543)
|
|
The Dell XPS 15 9500 has a large touchpad without any visible markers
for the touchpad buttons. Since the ModelTouchpadVisibleMarker quirk is
enabled by default for all Dell touchpads, the middle button area ends
up too small. Disable the quirk again for this specific model.
Fixes #545
Signed-off-by: Jef Driesen <jefdriesen@telenet.be>
(cherry picked from commit 4ce0d41b3a2069132aa258054f16aafaa324b167)
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Summary: we expect add, change or remove but kernel 4.12 added bind and
unbind. These events were previously discarded by udevd. Our rules should
handle any event *but* remove, so update as suggested in the announce email
linked below.
For a longer explanation, see the system 247rc2 announcement
https://lists.freedesktop.org/archives/systemd-devel/2020-November/045570.html
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit cd37dcfa66d59ecbdf787ee1aa34bb65f2a38b6d)
|
|
All minor:
- execdir does not need initialization, it's not used until written to
- 'newest' could be NULL
- zalloc(-1) confuses coverity
- 't' is never used in that test
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit cfd8e6c76c9be6c4ebdbc4e822762be4a30142e6)
|
|
nread is the number of bytes put into the buffer, let's terminate it there
instead of one byte over. This only worked because execdir was initialized to
zero.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 34fe17f72353b5fe65724390e4ec384ec848499a)
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Related #533
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 11d517f9694efbc625d2ea078d4b9df3e2fa8d43)
|
|
Two cases where this can happen: system is currently slow and delaying events,
n which case we'll get a burst and it'll show up in the log files anyway. Or
the system is generally slow and we get these warnings all the time. In the
latter case, let's not spam the log.
Fixes #533
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 5faa3b7ae92abb7860b05e85dcdd402e2050ed72)
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
The kernel has since added a bunch of keys in the range between
KEY_ONSCREEN_KEYBOARD and BTN_TRIGGER_HAPPY. Let's designate those as keys so
we handle them correctly.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit a80fe325032053792c7ee14d77f76cd41c4c47f7)
|
|
The current defaults detect force presses as palm or thumb.
The values provided here work for a 99% accurate palm/thumb detection
and provide close zero false positives in my tests.
Signed-off-by: Davide Depau <davide@depau.eu>
(cherry picked from commit ec939611fd2bda5bf379d79295a0c9b4282e3b23)
|
|
ALPS i2c touchpad support ABS_PRESSURE and ABS_MT_PRESSURE capabilities,
The default threshold 130 is too easy to across while finger movement.
It will cause the cursor stalled after the threshold is achieved, which
impacts user experience.
Test with some ALPS touchpads 0488:101A, 0488:101D, 0488:101E, the value
180 is good on those platforms.
Signed-off-by: Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
(cherry picked from commit f0997536a7a3e384bfe64b67c5c1f874656042c6)
|
|
Some ALPS touchpad send the occasional 4095/0 event on slot 1 during
two-finger interaction before snapping back to the actual position of the
finger. There doesn't seem to be a specific heuristic to predict this so let's
hardcode those values. When detected, overwrite the current touch point with
the position of the last point. This will likely cause a small pointer jump
when the finger later moves to the real position but based on #492 this could
be a second later, so all bets are off anyway.
Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/492
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 0c5112155600629fc6ac8d927d66118554180ecc)
|
|
Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/520
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit e926d3d9193ed8380fcb09072d62e697fdc90572)
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 36f1c85b1e8064efd8ef6d5e9cf47e2f7151b5dd)
|
|
Signed-off-by: Alyssa Ross <hi@alyssa.is>
(cherry picked from commit 81e6179b1eab30790d24f94d18630ce29af7be3c)
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Two devices that were affected by the regression fixed with #517
Test devices taken from:
https://gitlab.freedesktop.org/libinput/libinput/-/issues/514
https://gitlab.freedesktop.org/libinput/libinput/-/issues/515
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
SW_MAX changed and the device_capability_nocaps_ignored test will fail on
older kernels. Change that test to use some other unhandled-by-libinput switch
code instead.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
libwacom has been removing ID_INPUT_JOYSTICK for years
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
There are a number of devices that have the ID_INPUT_JOYSTICK tag set by udev,
usually because of seemingly random event codes set. We cannot rely on
ID_INPUT_JOYSTICK to be accurate enough.
Fixes #517
This reverts commit eededbeb7faa2b6182c02a84884f54c1cb1d8a2a.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
with help from
https://github.com/libratbag/libratbag/blob/master/data/devices/\
logitech-MX-Master.device
Signed-off-by: haarp <main.haarp@gmail.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
This used to do nothing, now at least it does the same thing as the
corresponding keyboard test. It merely tests the switch going on/off while a
touchpad is present, so short of an unexpected error message or a crash this
test doesn't actually test for any specific behavior.
Fixes #502
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Diego Abad <dabada83@gmail.com>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
This is not a package intended for, it's a job to fail when we accidentally
change the file list. An rpmbuild job like this was what detected
f15da0f10890467712222410233c0bec9faefdd0.
The spec file resembles the Fedora one but has BuildRequires removed (we rely
on the container for that).
The same task could be achieved by keeping a file list and comparing the
installed tree but since I had the rpm spec file already, let's use that for
now.
This requires meson 0.55 which hit F32 yesterday.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
This touchpad has firmware that seems to buffer events. In the words of the
reporter:
In usage, it feels like motions vary between smooth and choppy; slow
movements are smooth and quick movements are choppy. It's as if the
touchpad aggregates quick movements and sends one big movement instead
of sending discrete events. To make the movement more natural, the
events preceding the jump should be of higher magnitude and the jump
less pronounced, but that's just not how the touchpad works, it seems.
In the actual event data this looks exactly like a pointer jump: small
movements, one big one, then small ones again. If we filter that large
movement out we prevent the user from moving quickly.
There's no way to detect this or work around this, so let's add a quirk that
disables the jump detection for this device.
Fixes #506
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
From commit 74e20e0ae01170fdc967e1a5cfeaea02ce57977a, bug report
https://bugzilla.redhat.com/show_bug.cgi?id=1565692
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
libwacom has been unsetting ID_INPUT_JOYSTICK for known tablets since 2015
(libwacom 0.12) so this comment is outdated. And the input-id udev builtin
never labels something as tablet *and* joystick. Which means: systemd sets
either tablet or joystick. For tablets that are known to libwacom the joystick
bit gets corrected and we only see the tablet bits.
Tablets unknown to libwacom remain as joysticks and are ignored but that's the
behavior we had anyway.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
A device may have ID_INPUT_JOYSTICK and ID_INPUT_KEY in which case it would
still get added, despite being a joystick device. Make sure we check only the
tablet and joystick bits - where a device has the joystick bit set but not the
tablet one we ignore it.
Note that this check will get removed in the next commit anyway, it's just
here to make tracking the change easier in the history (and figuring out where
potential regressions come from).
Fixes #415
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
No effect on the test results because we never use ABS_Y anyway for multitouch
devices.
Fixes #505
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Missing from a0643a9c9879e569c2a47b13f203561de8031cc0
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Putting an EVIOCGRAB on the device before sending those events means no-one
else sees those events - particularly upower. This means no-one else knows the
lid is on or off and thus we never blank the screen (or suspend/shut down but
those are inhibited anyway).
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Symmetrical to litest_create_context(), this allows us to store special data
in that context that we have access to during the tests.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
We test lid switch events which are independently handled by Upower. Let's
make sure nothing else can tell logind to suspend or shut down while we're
running.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
This allows us to run the option parsing test without getting interrupted by a
million debug-gui windows popping up for half a second.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Ryo Munakata <ryomnktml@gmail.com>
|
|
This requires the COVERITY_SCAN_TOKEN as listed on the project settings page
in coverity itself. The intention here is to run this as a scheduled job, with
the pipeline schedule itself controlling the branch name etc. This way we can
keep the gitlab CI simple enough and just check for COVERITY_SCAN_TOKEN
itself.
This job shouldn't ever fail unless coverity is down (we'll fix that then),
the results of the coverity run are sent to the user that owns the the
scheduled pipeline, i.e. me.
Because coverity does not currently work on F32 (invalid GNU version number:
101), we force this to run on F31.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|