diff options
| author | Jehan <jehan@girinstud.io> | 2017-12-24 19:39:39 +0100 |
|---|---|---|
| committer | Jehan <jehan@girinstud.io> | 2017-12-24 19:47:05 +0100 |
| commit | df67ae4fe0db0f3da3698e2002cb90e52eb65a4d (patch) | |
| tree | bbc164eca00e0a7ad76e8ffe7d7d9e54bc1ef15f | |
| parent | cd617d181de03a7a13c2020e6c73cd14585e24b6 (diff) | |
CMake: get rid of some commented code.
It says that's for Win32 platform and uses the install prefix as library
prefix. But that's not at all the same kind of prefixes!
CMAKE_INSTALL_PREFIX expected value is the path to install the lib (what
is called the "installation prefix"), whereas CMAKE_*_LIBRARY_PREFIX are
the prefix on the file name (usually "lib" on UNIX-like systems).
Anyway I don't see a need to change this value. It will be called
"libuchardet.dll" on Win32. I don't see the problem.
Also this code was already commented out, and compilation and usage for
Win32 works just fine without it. :-)
| -rw-r--r-- | CMakeLists.txt | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index e212b4a..9d25a47 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,13 +23,6 @@ set ( set(CMAKE_CXX_STANDARD 11) set(CMAKE_CXX_STANDARD_REQUIRED ON) -######## Windows - -#if (WIN32) -# set(CMAKE_SHARED_LIBRARY_PREFIX ${CMAKE_INSTALL_PREFIX}) -# set(CMAKE_STATIC_LIBRARY_PREFIX ${CMAKE_INSTALL_PREFIX}) -#endif (WIN32) - ######## Directory include(GNUInstallDirs) |