From 4e9d58d926695cefc727170c9ffc4269c5a76581 Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Wed, 15 Feb 2012 15:29:58 +0100 Subject: Remove MUTE values from call stream/channel It is still unsure how mute should be implemented --- spec/Call_Stream_Interface_Media.xml | 14 +----------- spec/Channel_Type_Call.xml | 42 +++++------------------------------- 2 files changed, 6 insertions(+), 50 deletions(-) diff --git a/spec/Call_Stream_Interface_Media.xml b/spec/Call_Stream_Interface_Media.xml index 2e3af472..d0db6995 100644 --- a/spec/Call_Stream_Interface_Media.xml +++ b/spec/Call_Stream_Interface_Media.xml @@ -80,18 +80,6 @@ data, and everything is going swimmingly. - - - The streaming implementation has been told to mute sending, - but it has not yet indicated that it has done so. - - - - - The streaming implementation has successfully muted sending, - and the local user's privacy is protected. - - SendingStateChanged to determine whether it should be sending media or not. It should not - need to listen to the Mute/Hold interfaces on the Call/Content. + need to listen to the Hold interfaces on the Call/Content. Feedback on success should be given via CompleteSendingStateChange. Failures should be reported via ReportSendingFailure. diff --git a/spec/Channel_Type_Call.xml b/spec/Channel_Type_Call.xml index a8beed08..7f03ea04 100644 --- a/spec/Channel_Type_Call.xml +++ b/spec/Channel_Type_Call.xml @@ -732,25 +732,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - - - The call has been muted by the local user, e.g. using the - Mute interface. This flag SHOULD only - be set if there is at least one Content, and all Contents - are locally muted (for the same reason as Locally_Held). - - - This flag exists to provide a simplified verson of MuteStateChanged, - to reduce the number of signals that need to be - listened to by a simple UI. - - - - - + This flag exists for observability of the SetRinging method (e.g. so that @@ -761,7 +743,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - + This flag exists for observability of the SetQueued method. It should be set @@ -771,7 +753,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - + The initiator of the call originally called a contact other than the current recipient of the call, but the call was then forwarded or @@ -781,7 +763,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - + This flag only occurs when the CallState is Ended. The call with this flag set has ended, but not all resources corresponding to the @@ -1216,21 +1198,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - - -

The call member has muted their participation in this call. Note - that many protocols will not signal this flag, so clients should - not rely on it being set.

- - -

This is a flag per member, not a flag for the call as a whole, - because in conference calls, any member could mute their own - streams.

- - - - - + This contact has merged this call into a conference. Note that GSM provides a notification when the remote party merges a call into a -- cgit v1.2.3 From a7d9a9c6e83c9481db816cb77bd5d11190c62057 Mon Sep 17 00:00:00 2001 From: Olivier Crête Date: Wed, 8 Feb 2012 13:08:59 +0100 Subject: Add possible error on FinishInitialCandidates --- spec/Call_Stream_Interface_Media.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/spec/Call_Stream_Interface_Media.xml b/spec/Call_Stream_Interface_Media.xml index d0db6995..24686e96 100644 --- a/spec/Call_Stream_Interface_Media.xml +++ b/spec/Call_Stream_Interface_Media.xml @@ -407,6 +407,16 @@ and then set the lowest priority candidate as the Raw UDP candidate. + + + + + The minimal required candidates have not been set. For + example, for an RTP protocol, at least one candidate on the + component 1 (RTP) must have been set. + + + -- cgit v1.2.3 From c144a624422d37a6bab8c43bf140caed788029ab Mon Sep 17 00:00:00 2001 From: Olivier Crête Date: Wed, 15 Feb 2012 16:52:02 -0500 Subject: Call: On a forwarded call, make the actor into the real actor Put the handle it is forwarded to into the details https://bugs.freedesktop.org/show_bug.cgi?id=44513 --- spec/Channel_Type_Call.xml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/spec/Channel_Type_Call.xml b/spec/Channel_Type_Call.xml index 7f03ea04..7f433978 100644 --- a/spec/Channel_Type_Call.xml +++ b/spec/Channel_Type_Call.xml @@ -826,6 +826,12 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. The value of this key has the same units and scale as AccountBalance. + +
forwarded-to - u
+
Optionally included when the + CallStateReason is + Forwarded. It indicates the handle to whom the Call was + forwarded.
 @@ -904,9 +910,12 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -

The call was forwarded. If known, the handle of the contact - the call was forwarded to will be indicated by the Actor member - of a Call_State_Reason struct.

+

The call was forwarded. If known, the handle of the + contact the call was forwarded to will be indicated by the + "forwarded-to" member of a + CallStateDetails dictionnary + in the CallStateChanged + signal.

 -- cgit v1.2.3 From 29564bc950fff54f16484aab2b37a50f394c4dd0 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Fri, 17 Feb 2012 11:38:08 +0100 Subject: Call:add forwarded-to-id key https://bugs.freedesktop.org/show_bug.cgi?id=44513 --- spec/Channel_Type_Call.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spec/Channel_Type_Call.xml b/spec/Channel_Type_Call.xml index 7f433978..3555b4f3 100644 --- a/spec/Channel_Type_Call.xml +++ b/spec/Channel_Type_Call.xml @@ -832,6 +832,11 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. CallStateReason is Forwarded. It indicates the handle to whom the Call was forwarded. + +
forwarded-to-id - s
+
The string that would result from inspecting the + forwarded-to key + (i.e. the contact's identifier in the IM protocol).
-- cgit v1.2.3