summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Hughes <richard@hughsie.com>2008-04-17 18:02:37 +0100
committerRichard Hughes <richard@hughsie.com>2008-04-20 21:58:26 +0100
commitae32b357ab7511c063f4ef0fff9ffbbaa7484f53 (patch)
treee1ec54a63bccf0cbb2c83361e32c97d92938f39f
parentb7b0462cd213be2f3bb4f3a558eec56c4b72e96f (diff)
convert the unused metadata signals into status signals. Now we get nice UI feedback
-rw-r--r--backends/yum/helpers/yumBackend.py25
-rwxr-xr-xbackends/yum2/helpers/yumDBUSBackend.py16
-rw-r--r--python/packagekit/backend.py9
-rw-r--r--python/packagekit/daemonBackend.py11
4 files changed, 19 insertions, 42 deletions
diff --git a/backends/yum/helpers/yumBackend.py b/backends/yum/helpers/yumBackend.py
index c01e528bc..41512adb8 100644
--- a/backends/yum/helpers/yumBackend.py
+++ b/backends/yum/helpers/yumBackend.py
@@ -189,15 +189,12 @@ groupMap = {
}
MetaDataMap = {
-'repomd.xml' : "repository",
-'primary.sqlite.bz2' : "package",
-'primary.xml.gz' : "package",
-'filelists.sqlite.bz2' : "filelist",
-'filelists.xml.gz' : "filelist",
-'other.sqlite.bz2' : "changelog",
-'other.xml.gz' : "changelog",
-'comps.xml' : "group",
-'updateinfo.xml.gz' : "update"
+ 'repomd' : STATUS_DOWNLOAD_REPOSITORY,
+ 'primary' : STATUS_DOWNLOAD_PACKAGELIST,
+ 'filelists' : STATUS_DOWNLOAD_FILELIST,
+ 'other' : STATUS_DOWNLOAD_CHANGELOG,
+ 'comps' : STATUS_DOWNLOAD_GROUP,
+ 'updateinfo' : STATUS_DOWNLOAD_UPDATEINFO
}
GUI_KEYS = re.compile(r'(qt)|(gtk)')
@@ -1509,11 +1506,11 @@ class DownloadCallback( BaseMeter ):
if pkg: # show package to download
self.base._show_package(pkg,INFO_DOWNLOADING)
else:
- if name in MetaDataMap:
- typ = MetaDataMap[name]
- else:
- typ = 'unknown'
- self.base.metadata(typ,name)
+ for key in MetaDataMap.keys():
+ if key in name:
+ typ = MetaDataMap[key]
+ self.base.status(typ)
+ break
self.base.sub_percentage(0)
else:
if self.lastPct != pct and pct != 0 and pct != 100:
diff --git a/backends/yum2/helpers/yumDBUSBackend.py b/backends/yum2/helpers/yumDBUSBackend.py
index 036162604..8a44d47c1 100755
--- a/backends/yum2/helpers/yumDBUSBackend.py
+++ b/backends/yum2/helpers/yumDBUSBackend.py
@@ -210,12 +210,12 @@ groupMap = {
}
MetaDataMap = {
- 'repomd' : "repository",
- 'primary' : "package",
- 'filelists' : "filelist",
- 'other' : "changelog",
- 'comps' : "group",
- 'updateinfo' : "update"
+ 'repomd' : STATUS_DOWNLOAD_REPOSITORY,
+ 'primary' : STATUS_DOWNLOAD_PACKAGELIST,
+ 'filelists' : STATUS_DOWNLOAD_FILELIST,
+ 'other' : STATUS_DOWNLOAD_CHANGELOG,
+ 'comps' : STATUS_DOWNLOAD_GROUP,
+ 'updateinfo' : STATUS_DOWNLOAD_UPDATEINFO
}
GUI_KEYS = re.compile(r'(qt)|(gtk)')
@@ -1968,12 +1968,12 @@ class DownloadCallback( BaseMeter ):
if pkg: # show package to download
self.base._show_package(pkg,INFO_DOWNLOADING)
else:
- typ = 'unknown'
+ typ = STATUS_DOWNLOAD_REPOSITORY
for key in MetaDataMap.keys():
if key in name:
typ = MetaDataMap[key]
break
- self.base.MetaData(typ,name)
+ self.base.StatusChanged(typ)
self.base.SubPercentageChanged(0)
else:
if self.lastPct != pct and pct != 0 and pct != 100:
diff --git a/python/packagekit/backend.py b/python/packagekit/backend.py
index b0124c0b5..92180fe01 100644
--- a/python/packagekit/backend.py
+++ b/python/packagekit/backend.py
@@ -127,15 +127,6 @@ class PackageKitBaseBackend:
print "data\t%s" % (data)
sys.stdout.flush()
- def metadata(self,typ,fname):
- '''
- send 'metadata' signal:
- @param type: The type of metadata (repository,package,filelist,changelog,group,unknown)
- @param fname: The filename being downloaded
- '''
- print "metadata\t%s\t%s" % (typ,fname)
- sys.stdout.flush()
-
def description(self,id,license,group,desc,url,bytes):
'''
Send 'description' signal
diff --git a/python/packagekit/daemonBackend.py b/python/packagekit/daemonBackend.py
index 8ff4b522b..06b909007 100644
--- a/python/packagekit/daemonBackend.py
+++ b/python/packagekit/daemonBackend.py
@@ -295,17 +295,6 @@ class PackageKitBaseBackend(dbus.service.Object):
@PKSignalHouseKeeper
@dbus.service.signal(dbus_interface=PACKAGEKIT_DBUS_INTERFACE,
signature='ss')
- def MetaData(self,typ,fname):
- '''
- send 'metadata' signal:
- @param type: The type of metadata (repository,package,filelist,changelog,group,unknown)
- @param fname: The filename being downloaded
- '''
- pklog.info("MetaData (%s, %s)" % (typ,fname))
-
- @PKSignalHouseKeeper
- @dbus.service.signal(dbus_interface=PACKAGEKIT_DBUS_INTERFACE,
- signature='ss')
def RequireRestart(self,type,details):
'''
send 'require-restart' signal: