summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gnoutcheff <daniel@gnoutcheff.name>2015-01-10 17:42:29 -0700
committerJames Simmons <jsimmons@infradead.org>2015-01-10 17:43:42 -0700
commit271c716f2060bc04a5ca8324c0d2c27473463206 (patch)
treeaa1fb04819c32846654192abc2771d6f26daf58a
parent00f4d9d7fedccd1e66d98113e76cbfff15722d51 (diff)
Make our implementation of xf86OutputFuncsRec->set_output() return TRUE.
Implementations of this function are expected to return TRUE when given a property that they don't recognize. Otherwise, properties set by the server core (e.g. EDID) will break. (See commit 33133a1 in xf86-video-intel.) Since we don't support any properties ourselves, we should always return TRUE. This is also needed to support clients that set custom output properties; i.e. gnome-shell likes to set _MUTTER_PRESENTATION_OUTPUT, and it works fine with other drivers but would crash with ValueError on openchrome. Signed-off-by: Daniel Gnoutcheff <daniel@gnoutcheff.name> Reviewed-by: James Simmons <jsimmons@infradead.org>
-rw-r--r--src/via_outputs.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/via_outputs.c b/src/via_outputs.c
index 0a23e81..1876937 100644
--- a/src/via_outputs.c
+++ b/src/via_outputs.c
@@ -166,7 +166,7 @@ static Bool
via_tv_set_property(xf86OutputPtr output, Atom property,
RRPropertyValuePtr value)
{
- return FALSE;
+ return TRUE;
}
static Bool
@@ -505,7 +505,7 @@ static Bool
via_dp_set_property(xf86OutputPtr output, Atom property,
RRPropertyValuePtr value)
{
- return FALSE;
+ return TRUE;
}
static Bool
@@ -680,7 +680,7 @@ static Bool
via_analog_set_property(xf86OutputPtr output, Atom property,
RRPropertyValuePtr value)
{
- return FALSE;
+ return TRUE;
}
static Bool