Add a FIXME, found by looking, no time to investigatedistro/collabora/milestone-2

1 files changed, 2 insertions, 0 deletions

diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index d151a7f3d..30af0e3ae 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -607,6 +607,7 @@ void MasterProcessSession::dispatchChild()
             sendTextFrame("error: cmd=load kind=internal");
 
             // We did not use the child session after all
+            // FIXME: Why do we do the same thing both here and then when we catch the IOException that we throw, a dozen line below?
             lock.lock();
             _availableChildSessions.insert(childSession);
             std::cout << Util::logPrefix() << "_availableChildSessions size=" << _availableChildSessions.size() << std::endl;
@@ -623,6 +624,7 @@ void MasterProcessSession::dispatchChild()
         Application::instance().logger().error(Util::logPrefix() + "Copying failed: " + exc.message());
         sendTextFrame("error: cmd=load kind=failed");
 
+        // FIXME: See above FIXME
         lock.lock();
         _availableChildSessions.insert(childSession);
         std::cout << Util::logPrefix() << "_availableChildSessions size=" << _availableChildSessions.size() << std::endl;