fdo#36690: Don't broadcast setting changes during painting of button.

Calling SetSettings() when the output device is Window causes it to
broadcast data change.  PushButton::Draw() in fact calls this method
when the button contains colors, which ends up broadcasting its change
via Window::DataChanged call.  But depending on the output device
this DataChanged call may end up painting it again, which basically
causes a recursive loop.

The solution is to make sure OutputDevice::SetSettings() is called ( which only
 changes the settings without doing anything else ) and *not* and derived
classes 'SetSettings()' method

Signed-off-by: Noel Power <noel.power@novell.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index c77d14aeb8..6932cdbaa5 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1522,7 +1522,7 @@ void PushButton::Draw( OutputDevice* pDev, const Point& rPos, const Size& rSize,
         else
             aStyleSettings.SetFaceColor( GetSettings().GetStyleSettings().GetFaceColor() );
         aSettings.SetStyleSettings( aStyleSettings );
-        pDev->SetSettings( aSettings );
+        pDev->OutputDevice::SetSettings( aSettings );
     }
     pDev->SetTextFillColor();