summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrzej Hunt <andrzej@ahunt.org>2017-08-02 13:25:56 +0200
committerAndrzej Hunt <andrzej@ahunt.org>2017-08-02 13:25:56 +0200
commit8ba2d59609b48b042f3f204de78ed78a8f656c82 (patch)
tree9a78c7bf99636f9d1a1f7963286e19da4e7842cf
parentf36de6979f9a83c0f7aad48456518b8256723d54 (diff)
findbugs: medium: UWF_UNWRITTEN_FIELD
It looks like I copied too much while refactoring in b96971e130d544a1917ceca91f0019500aaf3907. The superclass (AbstractSlideFragment) already has its own IntentsReceiver which it handles correctly, I managed to cargo-cult the cleanup code but we never bother to initialise or use it in PointerFragment.
-rw-r--r--android/sdremote/mobile/src/main/java/org/libreoffice/impressremote/fragment/slides/PointerFragment.java18
1 files changed, 0 insertions, 18 deletions
diff --git a/android/sdremote/mobile/src/main/java/org/libreoffice/impressremote/fragment/slides/PointerFragment.java b/android/sdremote/mobile/src/main/java/org/libreoffice/impressremote/fragment/slides/PointerFragment.java
index b74490b..22ce3b3 100644
--- a/android/sdremote/mobile/src/main/java/org/libreoffice/impressremote/fragment/slides/PointerFragment.java
+++ b/android/sdremote/mobile/src/main/java/org/libreoffice/impressremote/fragment/slides/PointerFragment.java
@@ -8,7 +8,6 @@
*/
package org.libreoffice.impressremote.fragment.slides;
-import android.content.BroadcastReceiver;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
@@ -32,7 +31,6 @@ import org.libreoffice.impressremote.communication.CommunicationService;
public class PointerFragment extends AbstractSlideFragment implements ServiceConnection, View.OnTouchListener {
private CommunicationService mCommunicationService;
- private BroadcastReceiver mIntentsReceiver;
private int displayheight, displaywidth, xoffset, yoffset;
private long nextUpdate = 0;
private static final int REFRESH_MILLIS = 40; //25 fps refresh
@@ -150,22 +148,6 @@ public class PointerFragment extends AbstractSlideFragment implements ServiceCon
}
@Override
- public void onPause() {
- super.onPause();
-
- unregisterIntentsReceiver();
- }
-
- private void unregisterIntentsReceiver() {
- try {
- getBroadcastManager().unregisterReceiver(mIntentsReceiver);
- } catch (IllegalArgumentException e) {
- // Receiver not registered.
- // Fixed in Honeycomb: Android’s issue #6191.
- }
- }
-
- @Override
public void onDestroy() {
super.onDestroy();