summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-05-07tdf#160924: SDK: typo SDK_HOME instead of OO_SDK_HOME for linuxlibreoffice-7-6Julien Nabet1-1/+1
Change-Id: I8ec2bc31b19cc6b724a6f7ea3238dda8cf60d4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167111 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 6aa2e8fe2b0b59e2fe20191decb9bd6202dabcc9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167073 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> (cherry picked from commit ee9f7d31348e917eb8ba5b007a6679e01ecdb37f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167081 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-07Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-6' to d0bb46f277349b8b379b46edd2d56b67496b6cb8 - update translations for 7.6.7 rc2 and force-fix errors using pocheck Change-Id: If3cf78a036f5575eb3f433e414dda1c39a6fdaf8
2024-05-07update creditsChristian Lohmaier1-1002/+1022
Change-Id: Ibdf64d7605c81e9006c1637a85a4a539993dffa6 (cherry picked from commit 6b62ff0eaf499eb8c2ed4af3413757f38bc97dcb)
2024-05-07tdf#160898: check for nullptrMike Kaganski3-4/+53
Regression after commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda (tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09) Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166997 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167037
2024-05-07tdf#160855 fix crash due to Skia's internal maximum pixel limitPatrick Luby1-2/+29
Somewhere in the tens of thousands of selected fill cells, the size of the VirtualDevice exceeds 1 GB of pixels. But Skia, at least on macOS, will fail to create a surface. Even if there is ample free memory, Skia/Raster will fail. The second problem is that even if you disable Skia, the crash is just delayed when a BitmapEx is created from the VirtualDevice and malloc() fails. Since this data flavor really triggers one or more system memory limits, lower the resolution of the bitmap by keeping the VirtualDevice pixel size within an arbitrary number of pixels. Note: the artibrary "maximum number of pixels" limit that that Skia can handle may need to be raised or lowered for platforms other than macOS. Change-Id: Ie087f2db152470aa70521fbe5fe6c7cedd8504af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167145 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 8d9f54165d28d83092667b7bfcd0ee48ade54c87) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167216
2024-05-07svx: Avoid divide by 0Xisco Fauli1-1/+1
See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs() Change-Id: Ie08c54d1a1b40bcc42da9f81c893f496fff433a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166626 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 90548039f09d4bc773bf6879a62d544adfa175db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166675 Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-05-06wrong ScContentTree::SelectEntryByName early return conditionCaolán McNamara1-1/+1
Change-Id: I974f5aea545a80b0e48b50e2a2eae0729ff59691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167174 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 18b70ec7d9c4a0288f206cb64708f87a83789c00) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167086 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-06tdf#160765 - Paste Special Dialog: Remember comments checkboxAndreas Heinisch2-1/+37
After the change of tdf#139858 the comments checkbox was not remembered anymore after closing the dialog. In order to fix this issue, additionally check not only the NOTE flag but also for the ADDNOTES one. Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins (cherry picked from commit 7e30434655754277bfa7ce7d8ec37b07181d2c92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166838 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 30524d5998d38b7e216b721859c72fbfc56a5b5a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166890
2024-05-05android-viewer translated using WeblateWeblate7-10/+10
Italian currently translated at 100.0% (130 of 130 strings) Change-Id: Idfe9d3792e40600e25962d308a41e7d021656f02 android-viewer translated using Weblate Asturian currently translated at 100.0% (130 of 130 strings) Change-Id: Iab80940321d3ab62100adde7698d4a1eb35faf44 android-viewer translated using Weblate French currently translated at 100.0% (130 of 130 strings) Change-Id: I995c8e851f5deb7ec9d0b516b2cf165c4a495d17 android-viewer translated using Weblate Armenian currently translated at 100.0% (130 of 130 strings) Change-Id: I3410f847926f3edb04c8cfe1c678dacadcbe830f android-viewer translated using Weblate Catalan currently translated at 100.0% (130 of 130 strings) Change-Id: I25f97372a8fc192b7b709b6266682e05efed65ed android-viewer translated using Weblate Spanish currently translated at 100.0% (130 of 130 strings) Change-Id: Ic57c48059312802e94c2bf810f13ede0bdac82d8 android-viewer translated using Weblate Turkish currently translated at 100.0% (130 of 130 strings) Change-Id: I856382c725f7d54c4dfddfb71489f75d7cd58ec7 Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Muhammet Kara <kara@libreoffice.org> Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com> Co-authored-by: Valter Mura <valtermura@gmail.com> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/ca/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/es/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/hy/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/tr/ Translation: android-viewer/android-strings-7-6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167132 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-05-03Update git submodulesXisco Fauli1-0/+0
* Update dictionaries from branch 'libreoffice-7-6' to 0c5d6db9f4d3e465547e3a177360662e0f475d62 - upgrade Ukrainian dictionaries to 6.4.4 Change-Id: Idf246940bdf58844212420975ab52c19b08327ec Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Andriy Rysin <arysin@gmail.com> (cherry picked from commit 0ca7301c3c00d6e7936fd912ba775d0008f7fee4) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166907 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-05-03tdf#153306 prevent subpixel shifting of X coordinatePatrick Luby1-0/+20
HACK: for some unknown reason, if the X coordinate of the path's bounds is more than 1024, SkBlendMode::kExclusion will shift by about a half a pixel to the right with Skia/Metal on a Retina display. Weirdly, if the same polygon is repeatedly drawn, the total shift is cumulative so if the drawn polygon is more than a few pixels wide, the blinking cursor in Writer will exhibit this bug but only for one thin vertical slice at a time. Apparently, shifting drawing a very tiny amount to the left seems to be enough to quell this runaway cumulative X coordinate shift. Change-Id: Iabe9078e416b0dde003ee61c88817ff970cc8d39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166768 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-04-30SfxViewFrame::Current() dereferenced without null checkCaolán McNamara3-8/+14
found with msvc -analyze and _Ret_maybenull_ Change-Id: Ia377822e93448dc61acd1482d34167c35a46836b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 95d3e0d478686c7fa84f0bb8c466a1082333a47b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166830 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166876
2024-04-29tdf#114287 tdf#159366 xmloff: ODF import: revert text:list overrideMichael Stahl3-74/+5
This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287 xmloff: ODF import: fix text:list override of list style" and subsequent commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and 1b2a6b98291cf8b7022951be19b915fe2a9e18e6. It turns out that there is actually a paragraph in ODF 1.2 and later that gives paragraph's indent priority over the list style's, which i unfortunately missed when investigating the above issues: 17.20 <style:list-level-label-alignment> ... The fo:text-indent and fo:margin-left attributes are evaluated only for paragraphs inside list items whose paragraph styles do not specify them. If one of the two properties, or both, are specified by the paragraph style, the text indent and/or left margin are taken from the paragraph style. In this case the paragraph style's properties are used to determine the indent and margin for the text lines and thus also the alignment position. This is usually interpreted as "on the same level", so applying a list-style at a paragraph style overrides the indents inherited from a parent paragraph style, but if the style then specifies its own indents that overrides the list style's indents. Furthermore it turns out that Google Docs now imports this bugdoc the same way as LO 7.5 does; unclear if that changed recently (it shows it like Word does in the preview, but like LO 7.5 does after opening it). This means the way MS Word imports the bugdoc, which remains unchanged, now looks like a bug and we should not change LO to be compatible with it (when the same structure is created in Word, storing to ODF and loading again, it looks different too). Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 546741148863ae0b2a25cc994a7323c8113cb573) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166717 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-29tdf#160765 - Save content for undo when pasting notesAndreas Heinisch2-1/+77
even if no content was changed after pasting special. Otherwise, the undo functionality crashes due to undoing a cell with no content where the annotation indicator will remain (unod/redo of note captions are handled via drawing undo). Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469 Tested-by: Jenkins Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit a1694b194c2b3e89250c5b79a69e7dd184b69976) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166524 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-29update creditsChristian Lohmaier1-1612/+1709
Change-Id: I92481956d041c4a5077aa7a56af2df3ab72fd9bf (cherry picked from commit e729fec8a9e73e9d013cb634d4bcbd8c43be4200)
2024-04-29tdf#160827: fix crash when retrieving _MarkAsFinal value (docx) (take 2)Julien Nabet1-1/+5
Change-Id: I3f2ad56a205877be54b0dbfe361b76db3436f5ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166798 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins (cherry picked from commit 45d2d90d2354a6a32297cde52c0041915499b19b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166726 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 2ed402dada3b8b64c6f23cf5afc068848ab1a528) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166834
2024-04-29tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuseMichael Stahl1-1/+2
This is obviously wrong, as ALG just pointed out: the aIter is at the end after the 1st loop, so the 2nd loop does nothing. Thx Gabor for checking all the reported bugs. (regression from commit db115bec9254417ef7a3faf687478fe5424ab378) Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit ac05822b8957d80018d3ce1cbf97cd9faa0dfe99) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166713 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-29sc: fix crash in ScColumn::SetEditText()Miklos Vajna1-0/+5
Crashreport: > SIG Fatal signal received: SIGSEGV code: 128 for address: 0x0 > program/libsclo.so > ScColumn::SetEditText(int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >) > sc/source/core/data/column3.cxx:2362 > program/libsclo.so > ScTable::SetEditText(short, int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >) > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395 > program/libsclo.so > ScDocument::SetEditText(ScAddress const&, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >) > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395 > program/libsclo.so > ScDocFunc::SetEditCell(ScAddress const&, EditTextObject const&, bool) > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395 > program/libsclo.so > (anonymous namespace)::finalizeFormulaProcessing(std::shared_ptr<(anonymous namespace)::FormulaProcessingContext>) > sc/source/ui/view/viewfunc.cxx:565 Change-Id: I331ca8784702fdcb0ebad6a0a73390dbe2615ece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e3ce4aad47c052dcd67107f7c91336f4ecc949be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166526 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-29Include config_crypto.h in curlinit.hxxEike Rathke1-0/+2
Otherwise if only curlinit.hxx was included, SYSTEM_OPENSSL could had never been defined but opensslinit.hxx if SYSTEM_OPENSSL is defined does not declare/define GetCABundleFile() leading to error: ‘GetCABundleFile’ was not declared in this scope Happened from linguistic/source/translate.cxx:7 Apparently a regression already from commit 4ace291f2f1e655db559117f6fd3edc3a82ec878 CommitDate: Sat Nov 11 18:09:09 2023 +0100 curl: mitigate migration to OpenSSL on Linux Change-Id: I9c8f089ceb881dbb460d5bc5438152d1ce0ca7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166775 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-04-26tdf#160714 use crop box for bounds of embedded PDF objectPatrick Luby2-5/+15
If there is no crop box, fallback to the media box just to be safe. Change-Id: I29f99a43e550cf09a1534c0aa01ffd6a55536fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166544 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 4b31f87e918c38a7eb30ceb85563a5c98b426da5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166672 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-23Resolves: tdf#160159 update spellchecking area colors when style changesCaolán McNamara2-0/+16
so for the case of using "automatic" for the document background the spelling checking textbox background area updates to match Change-Id: I8723afb946176596b0a5fa43aa3bb3c036dee12c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165476 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165630
2024-04-22tdf#156146 tdf#159903 sw: add unit testsMichael Stahl6-5/+348
Unfortunately the actual computed margins are not stored in text formatting data structures so are only available directly from SwTextMargin. Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166222 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-22tdf#159903 xmloff: ODF import: fix bug in margin compatibility overrideMichael Stahl1-0/+8
The check for the property being set was wrong: the state in a parent style may be DIRECT_VALUE but a derived style may have a list style set, which effectively overrides the ParaLeftMargin and ParaFirstLineIndent. Fix this so that the compatibility override only happens when required. (regression from commit 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d) Change-Id: I6c8ca493df946afcb48a63c01c132620bcd7b390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166257 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 1b2a6b98291cf8b7022951be19b915fe2a9e18e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166218 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-22bump product version to 7.6.8.0.0+Christian Lohmaier1-1/+1
Change-Id: Id143d0d8dc696aaa7639dae169e553f1a11d7137
2024-04-22Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-6' to f33641b618682a4cac0c330f341a80bbdfbf0a02 - update translations for 7.6.7 rc1 and force-fix errors using pocheck Change-Id: I3080467cb48d722ced33ba4e338fc9961675167a
2024-04-22postgresql: upgrade to release 13.14Xisco Fauli1-2/+2
Change-Id: Ia9607fd9c8dad9d5936e867ad76b18a476f1057f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165278 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit e311a6a09d753fb566f248d653434f10a4645e63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165238 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22framework: MenuBarManager: fix WNT crash if queryDispatch() throwsMichael Stahl1-1/+10
a Java extension throws RuntimeException from queryDispatch(), which is translated to a C++ exception and thrown by the mscx_uno bridge, and this is apparently not handled anywhere (Visual Studio says "Unhandled Exception"), and what happens then apparently is the exception goes poof and vanishes, and normal return from the mscx_uno bridge code happens, but the out parameter used for the return value is never initialised, and then the uno::Reference move assignment operator crashes. Change-Id: I21535fcf0ab4ec30a712d01b5039b7e2fb7b09d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165081 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 447a15f4772bcbc9366cfa43b92c55ae644e9b03) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165114 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-22Update translation files for android-viewerWeblate1-0/+73
Updated by "Remove blank strings" hook in Weblate. Change-Id: Ifd652224539487f9728e89416e48ebfdf701f36f android-viewer translated using Weblate Interlingua currently translated at 53.8% (70 of 130 strings) Change-Id: I2f3ad2c06d7761c642cdf685d04ad3b63af74d0e Added translation for android-viewer using Weblate (Interlingua) Change-Id: I966ec95ffde1524395be9444984c1a249a3183ab Co-authored-by: SoftInterlingua <softinterlingua@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Weblate <noreply@weblate.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-7-6/ia/ Translation: android-viewer/android-strings-7-6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166117 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-18Update git submodulesJuan José González1-0/+0
* Update helpcontent2 from branch 'libreoffice-7-6' to 774b8b7a6b2abee14b1badeee35470d2acccea2c - Move z-index rule to CSS stylesheet we control Previously a fix was pushed to prism css file, which can be changed by the upstream project. Instead overwrite the rule in our files. Change-Id: I549b05d4a359343ae0fe09831644a2eed8fb0474 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166076 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 2b438594148c4ee94cb632e7a3d3b64b547706d5) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166210 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-17tdf#129701 Skip empty cell: treat last columnLaurent Balland3-2/+85
This is a combination of 2 commits. tdf#129701 Skip empty cell: treat last column When pasting data as text, with "Skip empty cells" not checked, empty cells in the last column of the source do not empty cells in destination, because there is nothing anymore to paste and while loop stops. This commit adds a flag to check if the last cell of each line is empty, and treat it if "Skip empty cells" is not checked. Add UITest to Copy data with empty cells; Paste Unformatted text, without "Skip empty cells"; Check data with empty cells in last column. xChange-Id: Idec823fb1c27b803f49c6d13d6c757ef0f41e437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160951 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> (cherry picked from commit e66ffda7c7f1e78dbca082ff7549ded121dc7356) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163536 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 60e0ebe633b1dee8bb2a66b9d133f5303749d8d5) tdf#129701 Follow-up of previous change According to comments in https://gerrit.libreoffice.org/c/core/+/163536 Follow-up of previous change xChange-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 47187acee758680cda8086b6e295ef7beea3491b) Change-Id: Idec823fb1c27b803f49c6d13d6c757ef0f41e437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2024-04-15Correct {bg-BG} formats with group separatorEike Rathke1-9/+9
The leading # digit before the separator was omitted. This never worked as intended. Change-Id: Idf8a6cf246b8db4e6d5361bc1c5f66c1c0c057c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166072 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2e29c97ec2ba64e5e26ee571e227db9dd2d752e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166090 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-12ofz#67906 Integer-overflowCaolán McNamara1-2/+2
Change-Id: I459bdeef6bb7577c5388202374c981c7b01fa137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165936 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-04-10Related: tdf#157480 use SSL_CERT_FILE on macOS tooCaolán McNamara3-3/+6
for SSL use by pyuno emailmerge another alternative mechanism that could work is to generate one with something like: "security find-certificate -a -p > cert.pem" ref: https: //hynek.me/articles/apple-openssl-verification-surprises/ Change-Id: I8bff2ca5bbbb4f2c2333a67e0281dd4fa0b06405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165625 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165921 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-10Related: tdf#157480 vcl,openssl: set SSL_CERT_FILE for bundled OpenSSLMichael Stahl5-22/+72
OpenSSL may read a CA certificate file from $SSL_CERT_FILE, if the client library calls SSL_CTX_set_default_verify_paths(); python's ssl module does it but apparently libcurl does not. So split the code from commit 3fc632c0261c75fb4079a5305e814698e791f75c and set the environment variable in ImplSVMain(), hopefully before any threads are spawned; seems to work for PyMailSMTPService. This needs to have SYSTEM_OPENSSL available in a config header. Change-Id: I63b747cb61bb236cf4f605bb9858e5b0083388fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159149 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 1472e2d68b9cff43b99069d3ba9439fff0a5684c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159283 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165597 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-10Resolves: tdf#154072 no effect when clicking some dropdown buttonsCaolán McNamara1-5/+17
when toolbar overflows. A problem since: commit b534ee2e972711af2dbaadf2190813054adda902 Date: Tue Nov 22 11:33:23 2022 +0000 Resolves: tdf#152155 use gtk's knowledge of relative widget positions rather than effectively emulate it poorly Change-Id: I18c08e43e9c0b642f2a30b5114d6f0a53f18a331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165610 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165634
2024-04-07tdf#159790 temporarily release mutex for child packagesPatrick Luby1-1/+16
This code is normally run on a separate thread so if a child package tries to acquire the solar mutex, a deadlock can occur if the main thread calls isRegistered() on this package or any of its parents. So, temporarily release this package's mutex while registering the child package. Change-Id: I45b534c44d5946637a5441927ed01a68aad4c448 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit cab028121bd9b620529b6492b3247ac48ac2082b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165832 Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-04-06sw: layout: remove superfluous pages again in InternalAction()Michael Stahl1-0/+6
The bugdoc has a very large header containing hidden text changes height when toggling Formatting Marks. When toggling on, it crashes, because UnHide() iterates the text frames in all headers, but after the first one empty pages at the end of the document are removed, so UAF. Remove the pages without content earlier; SwLayAction::InternalAction() already does it after the "normal" page loop, but the 2nd page loop following that may also move content off pages, so do it again. Change-Id: Iaae6a16842b3494f25cba8fc036d15049b71961f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165801 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 759d822dac5edc6104ce61b70c578425d9f2470d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165728 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-05Resolves tdf#154209 - Fixes resize issue in Index Entry dialogHeiko Tietze1-0/+1
Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165724 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-04Update git submodulesJuan José González1-0/+0
* Update helpcontent2 from branch 'libreoffice-7-6' to c6d3ab55898217c994d232df5ac14f7e0f4ec8c6 - tdf#160467 Remove z-index in prism code block Right now code renders on top of header section. Remove z-index to fix it. Change-Id: Ic0cf226275eae1656107de27907a94af256d5555 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165768 Tested-by: Jenkins Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit c89178e82abacbb240e571fcbd9bd0f76b40642d) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165720
2024-04-03Fix liborcus missing filesystem::file_size linker errorThorsten Behrens1-0/+5
On baseline gcc 8.3.1, liborcus-parser is missing a few of those experimental stdc++ symbols: liborcus-parser-0.18.so.0: undefined symbol: _ZNSt10filesystem9file_sizeERKNS_4pathE" Change-Id: I253d45d5966f0e99143b1fe983bd4d336178cd66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163207 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-04-02tdf#159790 eliminate deadlock on main threadPatrick Luby1-2/+6
A separate thread may have already acquired m_aMutex and that thread will then try to acquire the solar mutex. However, when the main thread calls this method, the main thread has already acquired the solar mutex. So, drop the desktop mutex before calling out. Change-Id: Ic87063266ac5101b866df9f24067a403e1417745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 89e23bb599104d3bde30878148e15cf4deb1593f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165710 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-02Resolves: tdf#157258 "Always autocorrect to" deletes the wordCaolán McNamara1-2/+21
instead of replacing it, affecting extensions like Grammalecte, LanguageTool, Antidote this began in: commit afa35742a4633db31b6d6c72cf45741506e9edfb Date: Sat Dec 11 21:09:39 2021 +0000 prefer more css::awt::XPopupMenu api but the underlying trap was introduced in: commit 6c84dc18062ec6aad71fd65a409373c274402991 Date: Wed Oct 6 10:16:39 2010 +0100 initial commit for vba blob ( not including container_control stuff ) which added creating a VCLXPopupMenu in VCLXMenu::getPopupMenu if there was a vcl PopupMenu in the vcl Menu which hadn't been created by calling VCLXMenu::setPopupMenu. That didn't take into account that VCLXPopupMenu (like VCLXMenu) takes ownership of the PopupMenu and will destroy it in its own dtor, so the sub menu Popup get destroyed if the VCLXPopupMenu is shorter lived than the VCLXMenu wrapping the parent Menu. Change-Id: Ic28c27670d846ee9d2ff77d834e43fc157924eb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165484 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 161bcfa1c8687570acde0947b0350c70e7021d85) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165613
2024-04-02Related tdf#160351: the field name can be shorter than two symbolsJulien Nabet1-1/+1
Change-Id: Ieb6b78b3f9802e66de642a9e708b11c55c0d9a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165285 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 02609da5ee8188cb00fc0b97052d2cc8d2576900) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165249 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit b94108edce1ea90044dba46156ab935410cd71ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165312 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-04-02Resolves: tdf#159498 Items in Template Manager dropdown should be left-alignedCaolán McNamara1-1/+2
Change-Id: I72d32793814b28b7452be701f0732dbd9dbbcb37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165483 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit b206e3b90a4ba34604a5e45faf3f05639ee89752) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165615
2024-04-01crash on deref null parent on attempting to find labelCaolán McNamara1-1/+1
ImplFindDlgCtrlWindow always calls ImplGetChildWindow with first arg which does pParent = ImplGetTopParentOfTabHierarchy( pParent ); vcl::Window* pWindow = ImplGetSubChildWindow( pParent, n, nIndex ); ImplGetSubChildWindow always derefs its first arg and ImplGetTopParentOfTabHierarchy only returns null if its input was null so ImplFindDlgCtrlWindow shouldn't be called with null program/libmergedlo.so(_ZNK3vcl6Window13ImplGetWindowEv+0x4)[0x7513e2a40e54] program/libmergedlo.so(+0x33ba57c)[0x7513e29ba57c] program/libmergedlo.so(+0x33ba97c)[0x7513e29ba97c] program/libmergedlo.so(+0x33baf64)[0x7513e29baf64] program/libmergedlo.so(+0x3378d47)[0x7513e2978d47] program/libmergedlo.so(_ZNK3vcl6Window30GetAccessibleRelationLabeledByEv+0x19c)[0x7513e297866c] program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x241)[0x7513e2a4b301] program/libmergedlo.so(_ZN6Dialog18DumpAsPropertyTreeERN5tools10JsonWriterE+0x2e)[0x7513e29b217e] program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x182)[0x7513e2a4b242] program/libmergedlo.so(_ZN3vcl3lok9dumpStateERN3rtl13OStringBufferE+0xc0)[0x7513e2d6ee80] Change-Id: I732550bd67c3af38627849a7d96d8ee6140008b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 23b72488140e7e2031e0071718d55d2b9e1c2bef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165322 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-01ofz#67708 ignore oversized colspansCaolán McNamara1-2/+10
that can't fit in SCCOL ignore negative colspan and rowspans too Change-Id: I79a010bcd7d9d84de70f6dac2e09614d6d448227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165480 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-01Resolves: tdf#157587 IconView scoll range not updatedCaolán McNamara1-0/+1
IconView::SetUpdateMode(true) doesn't update the scroll range for any changes that might have taken place while updates were suspended. The similar SvImpLBox::UpdateAll() for "normal" lists does this update, so do the equivalent update here too. Noticeable since: commit 666925f2ab06e690c41c470713dc83f2d752bfb7 Date: Sat Jun 3 15:23:15 2023 +0100 perf: use freeze/thaw around block insert of multiple icons Change-Id: I318fc4509c6906161eabf3b312f311cb97ac063a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165485 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 57428bfc71762687594c3c0fa62cdff391dda3f9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165612 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-04-01null deref of mpSidebarControllerCaolán McNamara1-57/+60
follow the pattern used in the rest of this and skip the branch that depends on mpSidebarController existing git show -w Change-Id: I739754b2af7ad09fa80c36693d8adbf173ece2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit d4d923f9db926d8b0b6eb3bb7b62f5a7a520c00d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165470 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit be02a86acef2e2b7a200225cd65a2f9af5d84944) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165473
2024-03-31ucb: webdav-curl: always set CURLOPT_NOBODY for HEADMichael Stahl1-10/+5
Otherwise there will be timeout that depends on when the server will close the connection, which varies by server but can be several minutes; getting a potential error document from the server for this one request when logging is enabled is less important. Change-Id: I505b014b148ba009c400d37d826c9edb8c3a6da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164838 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit c8400f5acc36d2cf0c007260bdc94534a53bba90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164823 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-31ucb: webdav-curl: only set CURLOPT_NOBODY for HEADMichael Stahl1-10/+9
Some testing with Apache httpd+mod_dav reveals that it usually sends a body with a 401 status, which causes the CURLE_WEIRD_SERVER_REPLY error code from curl. So we should either ignore this error in case there's a HTTP status too, or stop using CURLOPT_NOBODY. The latter seems to have no downside, except for HEAD requests, where strangely the server keeps the connection open and curl waits for 5 seconds for no body to arrive, blocking the UI, so continue to use CURLOPT_NOBODY for HEAD. The other methods don't seem to block. It turns out that the SAL_LOG-dependent setting of g_NoBody turned HEAD into GET anyway if logging is enabled, so explicitly set the method. Change-Id: Ibe2eef8e7a827d4e356ba37c4b56bee0be3b9c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164569 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e0259d4c0951c4dd77c74d08b9d905728d4c8dfd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164508 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>