summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReinhard Speyerer <rspmn@arcor.de>2019-08-20 22:19:10 +0200
committerAleksander Morgado <aleksander@aleksander.es>2019-09-08 14:47:49 +0200
commit9e1781a074169095bceaeff0fe0230d71fa1e531 (patch)
treefc0cd4a10d8fb9a75f76c7b46240b6f175ae3d76
parentc196a9aa6f958690c6481598a785df3bb99ca762 (diff)
libqmi-glib: use ((guint64) 1) << 31 for QMI_*_LTE_BAND_*_EUTRAN_32
The current definitions of QMI_*_LTE_BAND_*_EUTRAN_32 get converted to a negative value (0xffffffff80000000) which causes side effects like the incorrect ModemManager to QMI band mapping in https://lists.freedesktop.org/archives/modemmanager-devel/2019-August/007371.html . Replace 1 << 31 with ((guint64) 1) << 31 for QMI_*_LTE_BAND_*_EUTRAN_32 to avoid this. Reported-by: Nick <mips171@icloud.com> Signed-off-by: Reinhard Speyerer <rspmn@arcor.de> (cherry picked from commit 56357d280dfc85861c9b9f9a8c087073f4011d96)
-rw-r--r--src/libqmi-glib/qmi-flags64-dms.h2
-rw-r--r--src/libqmi-glib/qmi-flags64-nas.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/libqmi-glib/qmi-flags64-dms.h b/src/libqmi-glib/qmi-flags64-dms.h
index d74e61f..644789a 100644
--- a/src/libqmi-glib/qmi-flags64-dms.h
+++ b/src/libqmi-glib/qmi-flags64-dms.h
@@ -206,7 +206,7 @@ typedef enum {
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_29 = 1 << 28,
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_30 = 1 << 29,
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_31 = 1 << 30,
- QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_32 = 1 << 31,
+ QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_32 = ((guint64) 1) << 31,
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_33 = ((guint64) 1) << 32,
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_34 = ((guint64) 1) << 33,
QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_35 = ((guint64) 1) << 34,
diff --git a/src/libqmi-glib/qmi-flags64-nas.h b/src/libqmi-glib/qmi-flags64-nas.h
index c3541cd..7f57df2 100644
--- a/src/libqmi-glib/qmi-flags64-nas.h
+++ b/src/libqmi-glib/qmi-flags64-nas.h
@@ -210,7 +210,7 @@ typedef enum {
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_29 = 1 << 28,
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_30 = 1 << 29,
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_31 = 1 << 30,
- QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_32 = 1 << 31,
+ QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_32 = ((guint64) 1) << 31,
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_33 = ((guint64) 1) << 32,
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_34 = ((guint64) 1) << 33,
QMI_NAS_LTE_BAND_PREFERENCE_EUTRAN_35 = ((guint64) 1) << 34,