| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
Also adds "quirk" flags to driver_data so other special case things
can be handled with less effort going forwards.
|
|
|
|
|
|
Having this should at least give us a slightly better idea about the
version that the user has installed. Obviously it is still not very
accurate (maybe a git hash would be good if available?), but it should
still be helpful overall.
|
|
|
|
|
|
The code is correct, but gcc thinks the pointer is still NULL after the
call. As obvious workaround don't seem to work, just disable the warning
for now.
|
|
|
|
|
|
Just a minor change, but makes the file a bit more readable.
|
|
|
|
The internal storage of this device can get messed up by other operating
systems, so it's handy to be able to clear it.
I'm not 100% sure whether the commands I've sent to the device are
exactly what is supposed to be used (just a guess), but it did seem to
work, and it even fixed another issue I had.
|
|
The API should return the recognized print, even if none of the prints
given in the gallery (or the one passed to verify) matched. Without this
the garbage-collection of left-over prints does not work, causing issues
after reinstall.
Fixes: #444
|
|
|
|
Prints may have an invalid date. Extend the checks so that this is also
caught in addition to a NULL date.
|
|
Otherwise you can't tell from the log whether parsing the body or header
failed.
|
|
In commit 5c28654d9 ("goodixmoc: Fix print template parsing") the length
check for the verify and duplicate check responses by requiring two
extra bytes at the end of the message.
There were also issues in other places where the length was not checked
correctly, including a scenario that could cause a read beyond the end
of the buffer.
Related: #444
|
|
|
|
|
|
New values taken from a newer version of the official driver.
|
|
* Allow FPI_PRINT_NBIS to be extended rather than overridden if a user
supplies an existing FpPrint template with data;
* Prints will only be extended if a device has the required feature.
For image-based devices this feature is added by default since they
typically do not have storage (this can be overridden at the child
class level).
Extending an existing FpPrint requires passing a template print with
existing data during the enrollment process. This is done because the
caller is responsible for maintaining the fingerprint database and doing
the necessary deserialization operations if needed. The existing
example program is updated to show how to do that.
|
|
|
|
Otherwise tightly looping SSMs (primarily SPI transfers), will flood the
logs in inappropriate ways.
|
|
Two of the printed variables were only calculated after the message was
printed, making the logged information less useful than it could be.
|
|
This ensures that we have processed all hotplug events before
considering enumeration to be complete. This is important due to USB
persist being turned off. At resume time, devices will disappear and
immediately re-appear. In this situatoin, enumerate could first see the
old state with a removed device resulting in it to not be discovered.
As a hotplug event is semingly emitted by the kernel immediately, we
can simply make sure to process this hotplug event before returning
from enumerate.
Closes: fprintd#119
|
|
Added description and fixed incorrect name in comment, so now gtkdoc
actually shows useful information.
|
|
|
|
|
|
|
|
|
|
The length is only a single byte in the transfer. However, the struct
had a uint32_t in that place, breaking the sizeof() calculation and
seemingly creating issues for certain lengths of user id strings (which
depend on the username).
Fix this by changing the type to uint8_t. Also add the initial 0x43
prefix byte and a byte of apparent padding that the struct contains.
Leave the two reserved bytes at the end, as they seem to actually have a
meaning (i.e. they are seemingly send in listings).
This effectively makes the struct one byte smaller, bringing it down to
127 bytes from 128 bytes.
Closes: #428, #404
|
|
This as per the same reasons of commit 63bfaf4, and without trailing new
lines such attributes aren't picked by umockdev in ubuntu and debian.
|
|
63CC: Dell Latitude series fingerprint sensor
|
|
Signed-off-by: hermanlin <herman.lin@emc.com.tw>
|
|
|
|
|
|
While useful, there are advantages for this to be done by the
surrounding code (i.e. fprintd). As such, remove the identify stage from
the goodix driver and rely on fprintd doing it for us.
One can probably argue that neither solution is perfect. Ideally, we
would probably return the information required to delete the old print
to the upper stack and let the driver/device handle the duplicate
checking.
However, for now this works well. We may need to reconsider this if we
get devices that do the duplicate checking transparently and just throw
an enroll error.
NOTE: The driver did not report any progress for the identify step. As
such, the number of enroll steps reported by the device remain the same.
Closes: #415
|
|
This is needed for the fprintd duplicate checking code. The information
is needed to delete stale prints automatically from the device.
Related: #415
|
|
This allows creating tests both for image and non-image devices using
the same script.
|
|
63BC: Dell XPS series fingerprint sensor
|
|
|
|
See https://github.com/systemd/systemd/pull/20756
|
|
|
|
Otherwise forks will not find the image and things fall apart (due to
the method of how we build the image).
|
|
It is needed by tests/test-generated-hwdb.sh and is not pulled in
indirectly anymore.
|
|
|
|
Really, it shouldn't matter, as there is no return. But adding the NULL
initializer does not harm either.
|
|
This fixes the flatpak build.
|
|
And update instructions for the simpler method.
Co-authored-by: Benjamin Berg <bberg@redhat.com>
|
